From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Xen PCI passthrough: convert to realize()
Date: Thu, 24 Dec 2015 10:23:37 +0800 [thread overview]
Message-ID: <567B5729.1010704@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1512231359061.26829@kaball.uk.xensource.com>
On 12/23/2015 10:03 PM, Stefano Stabellini wrote:
> On Wed, 23 Dec 2015, Cao jin wrote:
[...]
>
>
>>> The patch as is fails to build:
>>>
>>> qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’:
>>> qemu/hw/xen/xen_pt_config_init.c:2061:42: error: ‘rc’ may be used
>>> uninitialized in this func
>>>
>>
>> really weird...last patch you remind me that it cannot compile, make me find
>> that my computer didn`t install xen-devel package, then I installed it right
>> away. But this time, it really can compile on my computer....anyway, I will
>> check it out later.
>
"it really can compile on my computer" means when I press make, the lines:
CC x86_64-softmmu/hw/xen/xen_pt_config_init.o
LINK x86_64-softmmu/qemu-system-x86_64
flash into the screen.
> I bet you don't have Xen PCI passthrough enabled. Do you have
> CONFIG_XEN_PCI_PASSTHROUGH=y in i386-softmmu/config-target.mak?
>
I am not sure before, I am not aware of this before:-[ this time, I did
with:
$ ./configure --enable-debug --enable-xen-pci-passthrough
--target-list=x86_64-softmmu
$ make clean; make
It can compile. Then I checked x86_64-softmmu/config-target.mak: the
CONFIG_XEN_PCI_PASSTHROUGH=y does exist.
[...]
>
--
Yours Sincerely,
Cao Jin
prev parent reply other threads:[~2015-12-24 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 10:23 [Qemu-devel] [PATCH] Xen PCI passthrough: convert to realize() Cao jin
2015-12-23 12:03 ` Stefano Stabellini
2015-12-23 13:08 ` Cao jin
2015-12-23 14:03 ` Stefano Stabellini
2015-12-24 2:23 ` Cao jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567B5729.1010704@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).