From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1aBvWz-0002F9-QA
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:21:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1aBvWu-0005BB-Qr
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:21:29 -0500
Received: from [59.151.112.132] (port=4293 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1aBvWu-0005AL-FA
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:21:24 -0500
References: <1450866192-31401-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<alpine.DEB.2.02.1512231135060.26829@kaball.uk.xensource.com>
	<567A9CD3.2040501@cn.fujitsu.com>
	<alpine.DEB.2.02.1512231359061.26829@kaball.uk.xensource.com>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <567B5729.1010704@cn.fujitsu.com>
Date: Thu, 24 Dec 2015 10:23:37 +0800
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1512231359061.26829@kaball.uk.xensource.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] Xen PCI passthrough: convert to realize()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org



On 12/23/2015 10:03 PM, Stefano Stabellini wrote:
> On Wed, 23 Dec 2015, Cao jin wrote:
[...]
>
>
>>> The patch as is fails to build:
>>>
>>> qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’:
>>> qemu/hw/xen/xen_pt_config_init.c:2061:42: error: ‘rc’ may be used
>>> uninitialized in this func
>>>
>>
>> really weird...last patch you remind me that it cannot compile, make me find
>> that my computer didn`t install xen-devel package, then I installed it right
>> away. But this time, it really can compile on my computer....anyway, I will
>> check it out later.
>
"it really can compile on my computer" means when I press make, the lines:

   CC    x86_64-softmmu/hw/xen/xen_pt_config_init.o
   LINK  x86_64-softmmu/qemu-system-x86_64

flash into the screen.

> I bet you don't have Xen PCI passthrough enabled. Do you have
> CONFIG_XEN_PCI_PASSTHROUGH=y in i386-softmmu/config-target.mak?
>

I am not sure before, I am not aware of this before:-[ this time, I did 
with:

   $ ./configure --enable-debug --enable-xen-pci-passthrough 
--target-list=x86_64-softmmu
   $ make clean; make

It can compile. Then I checked x86_64-softmmu/config-target.mak: the 
CONFIG_XEN_PCI_PASSTHROUGH=y does exist.

[...]
>

-- 
Yours Sincerely,

Cao Jin