From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBw2V-0005H1-Sk for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:54:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBw2Q-0002Lc-SL for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:54:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBw2Q-0002LX-Mz for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:53:58 -0500 References: <1450850771-42884-1-git-send-email-yanmiaobest@gmail.com> <9631C52C-3397-4A1C-AA02-24E1BC78DB9E@daynix.com> From: Jason Wang Message-ID: <567B5E3D.2090405@redhat.com> Date: Thu, 24 Dec 2015 10:53:49 +0800 MIME-Version: 1.0 In-Reply-To: <9631C52C-3397-4A1C-AA02-24E1BC78DB9E@daynix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/5] correct some register return values for vxmnet3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman , Miao Yan Cc: qemu-devel@nongnu.org On 12/23/2015 02:29 PM, Dmitry Fleytman wrote: > Reviewed-by: Dmitry Fleytman > >> On 23 Dec 2015, at 08:06 AM, Miao Yan wrote: >> >> Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO, >> VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and >> returns -1 on all of them. >> >> This patchset makes them return correct values. >> >> Changes in v2: >> - return 0 on unknown command >> Changes in v3: >> - rename VMXNET3_DEVICE_VERSION to VMXNET3_UPT_REVISION >> >> Miao Yan (5): >> net/vmxnet3: return 1 on device activation failure >> net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command >> net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO >> net/vmxnet3: return 0 on unknown command >> net/vmxnet3: rename VMXNET3_DEVICE_VERSION to VMXNET3_UPT_REVISION >> >> hw/net/vmxnet3.c | 29 +++++++++++++++++++++++++---- >> 1 file changed, 25 insertions(+), 4 deletions(-) >> >> -- >> 1.9.1 >> Applied in my -net. Thanks