From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aBwWw-0005Bt-3m
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 22:25:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aBwWv-0000mA-9Q
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 22:25:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aBwWv-0000m4-4G
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 22:25:29 -0500
References: <1450856601-4944-1-git-send-email-lizhijian@cn.fujitsu.com>
	<1450856601-4944-3-git-send-email-lizhijian@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <567B65A2.8040305@redhat.com>
Date: Thu, 24 Dec 2015 11:25:22 +0800
MIME-Version: 1.0
In-Reply-To: <1450856601-4944-3-git-send-email-lizhijian@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] net/dump: fix nfds->filename leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhijian <lizhijian@cn.fujitsu.com>, qemu-devel@nongnu.org



On 12/23/2015 03:43 PM, Li Zhijian wrote:
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>  net/dump.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/net/dump.c b/net/dump.c
> index ce16a4b..347b5ca 100644
> --- a/net/dump.c
> +++ b/net/dump.c
> @@ -329,6 +329,13 @@ static void filter_dump_instance_init(Object *obj)
>                              file_dump_set_filename, NULL);
>  }
>  
> +static void filter_dump_instance_finalize(Object *obj)
> +{
> +    NetFilterDumpState *nfds = FILTER_DUMP(obj);
> +
> +    g_free(nfds->filename);
> +}
> +
>  static void filter_dump_class_init(ObjectClass *oc, void *data)
>  {
>      NetFilterClass *nfc = NETFILTER_CLASS(oc);
> @@ -343,6 +350,7 @@ static const TypeInfo filter_dump_info = {
>      .parent = TYPE_NETFILTER,
>      .class_init = filter_dump_class_init,
>      .instance_init = filter_dump_instance_init,
> +    .instance_finalize = filter_dump_instance_finalize,
>      .instance_size = sizeof(NetFilterDumpState),
>  };
>  

Applied to my -net.

Thanks