From: Paolo Bonzini <pbonzini@redhat.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] meson: Use find_program() to resolve the entitlement.sh script
Date: Mon, 24 Jan 2022 14:41:22 +0100 [thread overview]
Message-ID: <567b658e-7283-769c-8c05-720b8546e34e@redhat.com> (raw)
In-Reply-To: <CAMVc7JXYAPLpiCO1CCKAcsSi7p9tj8nQJOB=usaMOvELUX31AA@mail.gmail.com>
On 1/24/22 10:04, Akihiko Odaki wrote:
> On Mon, Jan 24, 2022 at 5:16 PM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> On 1/22/22 11:20 AM, Philippe Mathieu-Daudé via wrote:
>>> Using ../configure without any particular option generates 31 targets
>>> on Darwin, and meson search for the entitlement.sh script 31 times:
>>>
>>> Program nm found: YES
>>> Program scripts/undefsym.py found: YES (/opt/homebrew/opt/python@3.9/bin/python3.9 /Code/qemu/scripts/undefsym.py)
>>> Program scripts/feature_to_c.sh found: YES (/bin/sh /Code/qemu/scripts/feature_to_c.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Program scripts/entitlement.sh found: YES (/Code/qemu/scripts/entitlement.sh)
>>> Configuring 50-edk2-i386-secure.json using configuration
>>> Configuring 50-edk2-x86_64-secure.json using configuration
>>>
>>> Use find_program() which seems to cache the script path once found.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>>> ---
>>> meson.build | 9 +++------
>>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> r~
>
> Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
>
Queued, thanks.
prev parent reply other threads:[~2022-01-24 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 0:20 [PATCH] meson: Use find_program() to resolve the entitlement.sh script Philippe Mathieu-Daudé via
2022-01-24 8:16 ` Richard Henderson
2022-01-24 9:04 ` Akihiko Odaki
2022-01-24 13:41 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567b658e-7283-769c-8c05-720b8546e34e@redhat.com \
--to=pbonzini@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).