From: Julien Grall <julien@xen.org>
To: eric.auger@redhat.com,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Mostafa Saleh <smostafa@google.com>
Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org,
qemu-devel@nongnu.org, alex.bennee@linaro.org, maz@kernel.org,
nicolinc@nvidia.com, richard.henderson@linaro.org,
marcin.juszkiewicz@linaro.org
Subject: Re: [PATCH v5 00/18] SMMUv3 nested translation support
Date: Thu, 18 Jul 2024 10:43:07 +0100 [thread overview]
Message-ID: <5684927d-d890-42be-841c-ece681502503@xen.org> (raw)
In-Reply-To: <1e7e750b-61bd-4822-8742-124bdf66a7c4@redhat.com>
Hi Eric,
On 17/07/2024 18:43, Eric Auger wrote:
> Hi Peter, Richard,
>
> On 7/17/24 17:09, Jean-Philippe Brucker wrote:
>> On Mon, Jul 15, 2024 at 08:45:00AM +0000, Mostafa Saleh wrote:
>>> Currently, QEMU supports emulating either stage-1 or stage-2 SMMUs
>>> but not nested instances.
>>> This patch series adds support for nested translation in SMMUv3,
>>> this is controlled by property “arm-smmuv3.stage=nested”, and
>>> advertised to guests as (IDR0.S1P == 1 && IDR0.S2P == 2)
>> For the whole series (3-9, 11, 12, 15, 16, 18):
>>
>> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>>
>> (and I think patch 16 is missing Eric's R-b)
>
> Jean-Philippe and I have followed up the progress of this series,
> Mostafa took into account all our comments and all the patches were
> reviewed. It seems to be in a pretty decent state so if you don't have
> any objection, please consider pulling it for 9.1.
>
> On my end I did some testing in non nesting mode with virtio-net/vhost
> and I have not noticed any regression.
> Would be nice if someone could send his T-b for the nested part though
> (Julien?).
I haven't yet tried the latest version. I will do that in the next
couple of days.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2024-07-18 9:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 8:45 [PATCH v5 00/18] SMMUv3 nested translation support Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 01/18] hw/arm/smmu-common: Add missing size check for stage-1 Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 02/18] hw/arm/smmu: Fix IPA for stage-2 events Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 03/18] hw/arm/smmuv3: Fix encoding of CLASS in events Mostafa Saleh
2024-07-17 15:07 ` Eric Auger
2024-07-17 15:58 ` Jean-Philippe Brucker
2024-07-17 15:59 ` Eric Auger
2024-07-15 8:45 ` [PATCH v5 04/18] hw/arm/smmu: Use enum for SMMU stage Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 05/18] hw/arm/smmu: Split smmuv3_translate() Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 06/18] hw/arm/smmu: Consolidate ASID and VMID types Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 07/18] hw/arm/smmu: Introduce CACHED_ENTRY_TO_ADDR Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 08/18] hw/arm/smmuv3: Translate CD and TT using stage-2 table Mostafa Saleh
2024-07-17 15:18 ` Eric Auger
2024-07-15 8:45 ` [PATCH v5 09/18] hw/arm/smmu-common: Rework TLB lookup for nesting Mostafa Saleh
2024-07-17 15:28 ` Eric Auger
2024-07-15 8:45 ` [PATCH v5 10/18] hw/arm/smmu-common: Add support for nested TLB Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 11/18] hw/arm/smmu-common: Support nested translation Mostafa Saleh
2024-07-17 15:28 ` Eric Auger
2024-07-15 8:45 ` [PATCH v5 12/18] hw/arm/smmu: Support nesting in smmuv3_range_inval() Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 13/18] hw/arm/smmu: Introduce smmu_iotlb_inv_asid_vmid Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 14/18] hw/arm/smmu: Support nesting in the rest of commands Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 15/18] hw/arm/smmuv3: Support nested SMMUs in smmuv3_notify_iova() Mostafa Saleh
2024-07-17 15:30 ` Eric Auger
2024-07-15 8:45 ` [PATCH v5 16/18] hw/arm/smmuv3: Handle translation faults according to SMMUPTWEventInfo Mostafa Saleh
2024-07-17 15:31 ` Eric Auger
2024-07-15 8:45 ` [PATCH v5 17/18] hw/arm/smmuv3: Support and advertise nesting Mostafa Saleh
2024-07-15 8:45 ` [PATCH v5 18/18] hw/arm/smmu: Refactor SMMU OAS Mostafa Saleh
2024-07-17 15:09 ` [PATCH v5 00/18] SMMUv3 nested translation support Jean-Philippe Brucker
2024-07-17 17:43 ` Eric Auger
2024-07-17 19:06 ` Peter Maydell
2024-07-18 9:43 ` Julien Grall [this message]
2024-07-19 15:36 ` Julien Grall
2024-07-19 15:57 ` Peter Maydell
2024-07-20 22:11 ` Mostafa Saleh
2024-07-22 9:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5684927d-d890-42be-841c-ece681502503@xen.org \
--to=julien@xen.org \
--cc=alex.bennee@linaro.org \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=maz@kernel.org \
--cc=nicolinc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=smostafa@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).