From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aF6NK-0008AP-3B
	for qemu-devel@nongnu.org; Fri, 01 Jan 2016 15:32:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aF6NH-00079k-D5
	for qemu-devel@nongnu.org; Fri, 01 Jan 2016 15:32:38 -0500
Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:36959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aF6NH-00079L-72
	for qemu-devel@nongnu.org; Fri, 01 Jan 2016 15:32:35 -0500
Received: by mail-wm0-x231.google.com with SMTP id f206so143707764wmf.0
	for <qemu-devel@nongnu.org>; Fri, 01 Jan 2016 12:32:34 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <BEDD3D6D-6ED9-4B23-AFAE-8ADB548D1ADE@gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5686E25E.7020204@redhat.com>
Date: Fri, 1 Jan 2016 21:32:30 +0100
MIME-Version: 1.0
In-Reply-To: <BEDD3D6D-6ED9-4B23-AFAE-8ADB548D1ADE@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Make rtl8139 network interface card
 compatible with Mac OS 10.4
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, jasowang@redhat.com



On 29/12/2015 18:59, Programmingkid wrote:
> @@ -699,6 +699,7 @@ static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr,
>  static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
>                                 void *buf, dma_addr_t len)
>  {
> +    memory_region_set_enabled(&dev->bus_master_enable_region, true);
>      return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
>  }

In other words, the driver is buggy and presumably would have never
worked on real hardware?

Paolo