[Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'

[Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'

[Denis V. Lunev]

    commit 31e38a22a0c5a25646f966f001e1f5513d5a186d
    Author: Olga Krishtal <okrishtal@virtuozzo.com>
    Date:   Fri Dec 4 09:42:04 2015 +0300

        qemu-char: append opt to stop truncation of serial file

has added the option to the runtime but does not added it to -help
output.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
CC: Dmitry Mishin <dim@virtuozzo.com>
CC: Eric Blake <eblake@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
---
Changes from v2:
- removed comment about libvirt in the description
- rephrased the description by the suggestions from Eric

Changes from v1:
- fixed default value to 'off'

    qemu-options.hx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 215d00d..3544788 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2099,7 +2099,7 @@ DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
     "-chardev vc,id=id[[,width=width][,height=height]][[,cols=cols][,rows=rows]]\n"
     "         [,mux=on|off]\n"
     "-chardev ringbuf,id=id[,size=size]\n"
-    "-chardev file,id=id,path=path[,mux=on|off]\n"
+    "-chardev file,id=id,path=path[,mux=on|off][,append=on|off]\n"
     "-chardev pipe,id=id,path=path[,mux=on|off]\n"
 #ifdef _WIN32
     "-chardev console,id=id[,mux=on|off]\n"
@@ -2254,7 +2254,7 @@ console with the given dimensions.
 Create a ring buffer with fixed size @option{size}.
 @var{size} must be a power of two, and defaults to @code{64K}).
 
-@item -chardev file ,id=@var{id} ,path=@var{path}
+@item -chardev file ,id=@var{id} ,path=@var{path} [,append=@var{on|off}]
 
 Log all traffic received from the guest to a file.
 
@@ -2262,6 +2262,9 @@ Log all traffic received from the guest to a file.
 created if it does not already exist, and overwritten if it does. @option{path}
 is required.
 
+@option{append} specifies that QEMU should append to the file. The file is
+truncated if the option is omitted or is specified as off.
+
 @item -chardev pipe ,id=@var{id} ,path=@var{path}
 
 Create a two-way connection to the guest. The behaviour differs slightly between
-- 
2.1.4

Re: [Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On 01/03/2016 08:07 AM, Denis V. Lunev wrote:
>     commit 31e38a22a0c5a25646f966f001e1f5513d5a186d
>     Author: Olga Krishtal <okrishtal@virtuozzo.com>
>     Date:   Fri Dec 4 09:42:04 2015 +0300
> 
>         qemu-char: append opt to stop truncation of serial file
> 
> has added the option to the runtime but does not added it to -help

s/does not added/did not add/

> output.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> CC: Dmitry Mishin <dim@virtuozzo.com>
> CC: Eric Blake <eblake@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> ---

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH v3 1/1] doc: document chardev option 'append'

[Paolo Bonzini]

On 04/01/2016 16:45, Eric Blake wrote:
> Reviewed-by: Eric Blake <eblake@redhat.com>

Fixed commit message and queued.

Paolo