From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 4/5] qmp: Add blockdev-mirror command
Date: Mon, 4 Jan 2016 21:02:18 +0100 [thread overview]
Message-ID: <568ACFCA.1070408@redhat.com> (raw)
In-Reply-To: <1450932306-13717-5-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On 24.12.2015 05:45, Fam Zheng wrote:
> This will start a mirror job from a named device to another named
> device, its relation with drive-mirror is similar with blockdev-backup
> to drive-backup.
>
> In blockdev-mirror, the target node should be prepared by blockdev-add,
> which will be responsible for assigning a name to the new node, so
> we don't have 'node-name' parameter.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Acked-by: Markus Armbruster <armbru@redhat.com>
> ---
> blockdev.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> qapi/block-core.json | 48 ++++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 50 +++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 159 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-04 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 4:45 [Qemu-devel] [PATCH v4 0/5] qmp: Add blockdev-mirror Fam Zheng
2015-12-24 4:45 ` [Qemu-devel] [PATCH v4 1/5] block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE Fam Zheng
2015-12-24 4:45 ` [Qemu-devel] [PATCH v4 2/5] block: Extract blockdev part of qmp_drive_mirror Fam Zheng
2015-12-24 4:45 ` [Qemu-devel] [PATCH v4 3/5] block: Add check on mirror target Fam Zheng
2015-12-24 4:45 ` [Qemu-devel] [PATCH v4 4/5] qmp: Add blockdev-mirror command Fam Zheng
2016-01-04 20:02 ` Max Reitz [this message]
2015-12-24 4:45 ` [Qemu-devel] [PATCH v4 5/5] iotests: Add test cases for blockdev-mirror Fam Zheng
2016-01-06 18:03 ` [Qemu-devel] [PATCH v4 0/5] qmp: Add blockdev-mirror Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568ACFCA.1070408@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).