From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGCEc-0001d9-Ia for qemu-devel@nongnu.org; Mon, 04 Jan 2016 16:00:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGCEb-0005KP-OL for qemu-devel@nongnu.org; Mon, 04 Jan 2016 16:00:10 -0500 References: <1450936225-4249-1-git-send-email-famz@redhat.com> <1450936225-4249-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <568ADD50.9020700@redhat.com> Date: Mon, 4 Jan 2016 22:00:00 +0100 MIME-Version: 1.0 In-Reply-To: <1450936225-4249-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vaU8TGa6wgCkEaeROj2XsJIkSGHt0sUrW" Subject: Re: [Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vaU8TGa6wgCkEaeROj2XsJIkSGHt0sUrW Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 24.12.2015 06:50, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. It's value should be ignored unless *Its > BDRV_BLOCK_OFFSET_VALID in ret is set. >=20 > Until block drivers fill in the right value, let's clear it explicitly > right before calling .bdrv_get_block_status. >=20 > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > block/io.c | 42 ++++++++++++++++++++++++++++-----------= --- > block/iscsi.c | 6 ++++-- > block/mirror.c | 3 ++- > block/parallels.c | 2 +- > block/qcow.c | 2 +- > block/qcow2.c | 2 +- > block/qed.c | 3 ++- > block/raw-posix.c | 3 ++- > block/raw_bsd.c | 3 ++- > block/sheepdog.c | 2 +- > block/vdi.c | 2 +- > block/vmdk.c | 2 +- > block/vpc.c | 2 +- > block/vvfat.c | 2 +- > include/block/block.h | 6 ++++-- > include/block/block_int.h | 3 ++- > qemu-img.c | 7 +++++-- > 17 files changed, 59 insertions(+), 33 deletions(-) >=20 [...] > diff --git a/include/block/block.h b/include/block/block.h > index db8e096..70b4984 100644 > --- a/include/block/block.h > +++ b/include/block/block.h The comment explaining BDRV_BLOCK_OFFSET_VALID should be changed accordingly (you could also say "fixed", because apparently it wasn't always bs->file; sometimes it was bs itself (in case of raw-posix, iscsi and sheepdog)). Max --vaU8TGa6wgCkEaeROj2XsJIkSGHt0sUrW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWit1QAAoJEDuxQgLoOKyt0VsIAKzhmLwJVQ/MaqDd1L1nYovY pbeLDJqCxYXlQ72L1bt5vzsbE1Mg2GblwjidcyCNNC2nv9/9ICkgiqhWSKIoujqu BTz31xqbb4uJdwd3n8fs88rxBTwnchDnbukVJUJCc++05RKC9xCEaKtAJdqxG2dZ bRmcF57pExCrNd6yvMH5z+sUTUZ2K6OP7hnZFMXMCpU3ZIB30f3P3YjM7kcIgqwX Ho/k5NFku+wPGvHb5lqpWjzfVGMFvRxZJt9FNoktnd4iFKM7C0ocxjOBE/D8OiG5 4+7hk1ecfWPrO1QmLwsBLZYZEI1O1vRtM1HvDzZzV7YQrVuQSIrmAc/G9OnmPlY= =73Qk -----END PGP SIGNATURE----- --vaU8TGa6wgCkEaeROj2XsJIkSGHt0sUrW--