From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGSGv-0002Rj-1x for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:07:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGSGo-0000oz-KO for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:07:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGSGo-0000oi-Dc for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:07:30 -0500 References: <1452000144-23805-1-git-send-email-drjones@redhat.com> From: Eric Blake Message-ID: <568BCE1A.8090007@redhat.com> Date: Tue, 5 Jan 2016 07:07:22 -0700 MIME-Version: 1.0 In-Reply-To: <1452000144-23805-1-git-send-email-drjones@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="afubFQhAmvB9EgIUQJ1nnbsh8FRSgciaK" Subject: Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones , qemu-devel@nongnu.org Cc: edgar.iglesias@gmail.com, alistair.francis@xilinx.com, crosthwaite.peter@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --afubFQhAmvB9EgIUQJ1nnbsh8FRSgciaK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/05/2016 06:22 AM, Andrew Jones wrote: > (Found by grepping for broken PRI users.) >=20 > Signed-off-by: Andrew Jones > --- > hw/dma/xilinx_axidma.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c > index b1cfa11356a26..2ab0772cd19ae 100644 > --- a/hw/dma/xilinx_axidma.c > +++ b/hw/dma/xilinx_axidma.c > @@ -180,10 +180,10 @@ static inline int streamid_from_addr(hwaddr addr)= > #ifdef DEBUG_ENET > static void stream_desc_show(struct SDesc *d) > { > - qemu_log("buffer_addr =3D " PRIx64 "\n", d->buffer_address); > - qemu_log("nxtdesc =3D " PRIx64 "\n", d->nxtdesc); > - qemu_log("control =3D %x\n", d->control); > - qemu_log("status =3D %x\n", d->status); > + qemu_log("buffer_addr =3D 0x%" PRIx64 "\n", d->buffer_address); > + qemu_log("nxtdesc =3D 0x%" PRIx64 "\n", d->nxtdesc); > + qemu_log("control =3D 0x%x\n", d->control); > + qemu_log("status =3D 0x%x\n", d->status); This is dead code. Nothing uses stream_desc_show() even when DEBUG_ENET is defined. I'd just delete the function and #ifdef altogether, instead.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --afubFQhAmvB9EgIUQJ1nnbsh8FRSgciaK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWi84aAAoJEKeha0olJ0NqGE8H/1ItcvIpUFzhq22s+ba4PjmB 1aB0KxfdPb6/1Ifv6LMD0PSwAXugacKEdD8q2ViaOX3Z/vi6tOv3nDoHCQnPRet3 Ss8qp5aMzmOqB1geJQAVuEMB2Fp05Mg0jAwpKnUaUOol44VsIueM6aSPBBneZz5z 7HujOGe3vz6Q5rQj7pJyfNaYrpih6B19QQlYdWcQ7oln2d2iM/6TvnoLOkTX4dEf xFxiXwftOohRz7u8hdApHnYRxxOSyLDYCC8JHNLgO5nXyd6ewgkEOBaammMkWDFW jbvwrd7fIT0WDqRV8/Ptfv+IVTZDkUQaoChsXNWayUKcBUlB9860CahEWJQnJ/U= =P86p -----END PGP SIGNATURE----- --afubFQhAmvB9EgIUQJ1nnbsh8FRSgciaK--