From: Eric Blake <eblake@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Laurent Vivier <lvivier@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings
Date: Tue, 5 Jan 2016 08:35:53 -0700 [thread overview]
Message-ID: <568BE2D9.3030906@redhat.com> (raw)
In-Reply-To: <20160105152421.GB4208@hawk.localdomain>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On 01/05/2016 08:24 AM, Andrew Jones wrote:
>>
>> I think there are too many quotes. This looks more correct:
>>
>> "env=%p frame_addr=0x%"PRIx64
>
> You're right. The trailing null strings don't break compilation, but don't do
> anything either.
>
> I'll send a v2 with those removed.
>
No need; it is already posted here:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03667.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-01-05 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 13:20 [Qemu-devel] [PATCH] trace-events: fix broken format strings Andrew Jones
2016-01-05 14:54 ` Laurent Vivier
2016-01-05 15:24 ` Andrew Jones
2016-01-05 15:35 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568BE2D9.3030906@redhat.com \
--to=eblake@redhat.com \
--cc=drjones@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).