From: Laurent Vivier <lvivier@redhat.com>
To: Andrew Jones <drjones@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] trace-events: fix broken format strings
Date: Tue, 5 Jan 2016 16:39:37 +0100 [thread overview]
Message-ID: <568BE3B9.4020201@redhat.com> (raw)
In-Reply-To: <1452008255-13068-1-git-send-email-drjones@redhat.com>
On 05/01/2016 16:37, Andrew Jones wrote:
> Fixes compiling with --enable-trace-backends
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> v2: also remove trailing null strings [Laurent]
>
>
> trace-events | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 6f036384a84f8..98ec748270a39 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1799,15 +1799,15 @@ qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const
> vhost_user_event(const char *chr, int event) "chr: %s got event: %d"
>
> # linux-user/signal.c
> -user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> -user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> -user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> -user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> +user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64
> +user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64
> +user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64
> +user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64
> user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)"
> user_handle_signal(void *env, int target_sig) "env=%p signal %d"
> user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d("
> user_queue_signal(void *env, int target_sig) "env=%p signal %d"
> -user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr "PRIx64 " current psw.addr "PRIx64""
> +user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr 0x%"PRIx64 " current psw.addr 0x%"PRIx64
>
> # io/task.c
> qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p"
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2016-01-05 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 15:37 [Qemu-devel] [PATCH v2] trace-events: fix broken format strings Andrew Jones
2016-01-05 15:39 ` Laurent Vivier [this message]
2016-01-05 15:50 ` Eric Blake
2016-01-07 4:34 ` Stefan Hajnoczi
2016-01-05 16:21 ` Greg Kurz
2016-01-06 9:25 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568BE3B9.4020201@redhat.com \
--to=lvivier@redhat.com \
--cc=drjones@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).