From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGTi4-0005o1-1h for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:39:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGThz-0004dB-Ub for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:39:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGThz-0004d5-OX for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:39:39 -0500 References: <1452008255-13068-1-git-send-email-drjones@redhat.com> From: Laurent Vivier Message-ID: <568BE3B9.4020201@redhat.com> Date: Tue, 5 Jan 2016 16:39:37 +0100 MIME-Version: 1.0 In-Reply-To: <1452008255-13068-1-git-send-email-drjones@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] trace-events: fix broken format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Mark Cave-Ayland , Greg Kurz On 05/01/2016 16:37, Andrew Jones wrote: > Fixes compiling with --enable-trace-backends > > Signed-off-by: Andrew Jones > --- > v2: also remove trailing null strings [Laurent] > > > trace-events | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/trace-events b/trace-events > index 6f036384a84f8..98ec748270a39 100644 > --- a/trace-events > +++ b/trace-events > @@ -1799,15 +1799,15 @@ qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const > vhost_user_event(const char *chr, int event) "chr: %s got event: %d" > > # linux-user/signal.c > -user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > -user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > -user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > -user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > +user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > +user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > +user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > +user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)" > user_handle_signal(void *env, int target_sig) "env=%p signal %d" > user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d(" > user_queue_signal(void *env, int target_sig) "env=%p signal %d" > -user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr "PRIx64 " current psw.addr "PRIx64"" > +user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr 0x%"PRIx64 " current psw.addr 0x%"PRIx64 > > # io/task.c > qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p" > Reviewed-by: Laurent Vivier