From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGZs6-0006Px-Ry for qemu-devel@nongnu.org; Tue, 05 Jan 2016 17:14:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGZs5-0003cO-OZ for qemu-devel@nongnu.org; Tue, 05 Jan 2016 17:14:30 -0500 References: <1451903234-32529-1-git-send-email-famz@redhat.com> <1451903234-32529-3-git-send-email-famz@redhat.com> From: John Snow Message-ID: <568C403F.2070809@redhat.com> Date: Tue, 5 Jan 2016 17:14:23 -0500 MIME-Version: 1.0 In-Reply-To: <1451903234-32529-3-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/13] typedefs: Add BdrvDirtyBitmap and HBitmapIter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org On 01/04/2016 05:27 AM, Fam Zheng wrote: > Following patches to refactor and move block dirty bitmap code could use this. > > Signed-off-by: Fam Zheng > --- > include/qemu/typedefs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index 78fe6e8..e83934e 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -10,6 +10,7 @@ typedef struct AddressSpace AddressSpace; > typedef struct AioContext AioContext; > typedef struct AllwinnerAHCIState AllwinnerAHCIState; > typedef struct AudioState AudioState; > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap; > typedef struct BlockBackend BlockBackend; > typedef struct BlockBackendRootState BlockBackendRootState; > typedef struct BlockDriverState BlockDriverState; > @@ -28,6 +29,7 @@ typedef struct EventNotifier EventNotifier; > typedef struct FWCfgIoState FWCfgIoState; > typedef struct FWCfgMemState FWCfgMemState; > typedef struct FWCfgState FWCfgState; > +typedef struct HBitmapIter HBitmapIter; > typedef struct HCIInfo HCIInfo; > typedef struct I2CBus I2CBus; > typedef struct I2SCodec I2SCodec; > Should the existing typedefs be removed? >> include/block/block.h:typedef struct BdrvDirtyBitmap BdrvDirtyBitmap; >> include/block/block.h:struct HBitmapIter; >> include/qemu/hbitmap.h:typedef struct HBitmapIter HBitmapIter;