From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGaO0-00019L-2u for qemu-devel@nongnu.org; Tue, 05 Jan 2016 17:47:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGaNz-0003MJ-8t for qemu-devel@nongnu.org; Tue, 05 Jan 2016 17:47:28 -0500 References: <1450717720-9627-1-git-send-email-eblake@redhat.com> <1450717720-9627-15-git-send-email-eblake@redhat.com> <568BE21F.6040300@redhat.com> From: Eric Blake Message-ID: <568C47F2.2050006@redhat.com> Date: Tue, 5 Jan 2016 15:47:14 -0700 MIME-Version: 1.0 In-Reply-To: <568BE21F.6040300@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QvAADID2UBRPFGe0GGMHNxRNjFDqmEAw9" Subject: Re: [Qemu-devel] [PATCH v8 14/35] qapi: Swap visit_* arguments for consistent 'name' placement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: Kevin Wolf , Alexander Graf , Eduardo Habkost , "open list:Block layer core" , "Michael S. Tsirkin" , Michael Roth , John Snow , Jason Wang , Markus Armbruster , QEMU , Keith Busch , Gonglei , "open list:sPAPR pseries" , Gerd Hoffmann , David Gibson , Paolo Bonzini , Igor Mammedov , Luiz Capitulino , Jiri Slaby , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QvAADID2UBRPFGe0GGMHNxRNjFDqmEAw9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/05/2016 08:32 AM, Eric Blake wrote: >> >> However, docs/qapi-code-gen.txt should be updated in a follow-up patch= =2E >=20 > D'oh - I knew I'd forget something :) You're right, of course. For that matter, several recent patches have tweaked generated code without updating the docs, such as 9f08c8ec dropping the automatic creation of a corresponding UserDefOneList type for the example as given. I'll bring it back in sync, but now I have to decide how much (or how little) to actually demonstrate in the docs (qapi-schema-test.json is a much more thorough testing mechanism for all the corner cases; the docs only have to demonstrate a couple of common examples). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QvAADID2UBRPFGe0GGMHNxRNjFDqmEAw9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWjEfyAAoJEKeha0olJ0Nqd0MH/jEJPgowkclVAHCr6KUwF6dy VRG6bMghLq7qgUWuaYAjIe7SS01ojrzOvbEjYYloVNEkwsCOKWst+mLM8TcDgcqL 1gF9xSj5cgoGOwggpdRHT8R6gdXmpJx9S8cxgN++TaJ3gXKTX1Yz2IaLjFNVn0xO ooxF2x6D9wyRxt3+jfzo7JGdnl7C+26AqlvcwLLKMeySoU7/qkqvUwVAcOZwDHMi +koUWYRrpdjM6OqVyFIMpHEAXM3MGdwbb3xKV8Uwp7y4KJF4E1FZGnx7rnstReRP 4BpFfq5LxwCdh3Mi/ByEPxWr47Ej5ILdYdY555Apc53jy+OS0vZMSFHJh6fbXlE= =ebGL -----END PGP SIGNATURE----- --QvAADID2UBRPFGe0GGMHNxRNjFDqmEAw9--