From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGbw0-00013E-I8 for qemu-devel@nongnu.org; Tue, 05 Jan 2016 19:26:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGbvx-00083V-CN for qemu-devel@nongnu.org; Tue, 05 Jan 2016 19:26:40 -0500 References: <1450717720-9627-1-git-send-email-eblake@redhat.com> <1450717720-9627-18-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <568C5F3A.509@redhat.com> Date: Tue, 5 Jan 2016 17:26:34 -0700 MIME-Version: 1.0 In-Reply-To: <1450717720-9627-18-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5BquXVAiHhxL1mBmxEDeHtl5cqSwa8urL" Subject: Re: [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' for struct/enum visit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , armbru@redhat.com, Michael Roth , Alexander Graf , "open list:sPAPR pseries" , Paolo Bonzini , Luiz Capitulino , =?UTF-8?Q?Andreas_F=c3=a4rber?= , David Gibson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5BquXVAiHhxL1mBmxEDeHtl5cqSwa8urL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/21/2015 10:08 AM, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the argument. > It's even hard to argue that it would be useful in a debugger, > as a stack backtrace also tells which type is being visited. >=20 > Therefore, drop the 'kind' argument as dead. >=20 > Signed-off-by: Eric Blake >=20 > --- > v8: rebase to 'name' motion > v7: new patch > +++ b/qapi/qapi-visit-core.c > @@ -2,6 +2,7 @@ > * Core Definitions for QAPI Visitor Classes > * > * Copyright IBM, Corp. 2011 > + * Copyright (C) 2015 Red Hat, Inc. Hmm (and more of a note to myself): Now that the year has rolled over, if I have a reason to spin v9, I'll have to remember to update all my Copyright lines to include 2016. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5BquXVAiHhxL1mBmxEDeHtl5cqSwa8urL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWjF87AAoJEKeha0olJ0NqSLkH/RThmOXSOPs84ttuQaobzgLP 9VrNaW+brY3gZnCcMPE/K8ifNhwDwJAjw/CNx+HQFkPtYr0TqQD/txRkBsU9TjYf LCsm77kqbBsnUwVGjKUcb4wXo8sGiBx+ofdtApuIltf/At7JekGLZrUMY/NnTc2d /+95I9myKUesqlZX6OvbpRvzmw405DhX2hI30dR9BaN5Exbn9zzzswfJnsYfKdtz cNxKYJJZoaEmE8V+9Fx8zmhbWpntFF/0bQ8SStO9WU2zAjIwBayF7MbSlXXJsTkY ERoRaQjXx40e/ZALKzeXv+x7wWV0xb3b0wx+IGTq4LfydMa7xCDA5pxIGJyHIbw= =laFl -----END PGP SIGNATURE----- --5BquXVAiHhxL1mBmxEDeHtl5cqSwa8urL--