From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1aGjgr-0004Vu-4N
	for qemu-devel@nongnu.org; Wed, 06 Jan 2016 03:43:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1aGjgn-0006xh-T2
	for qemu-devel@nongnu.org; Wed, 06 Jan 2016 03:43:33 -0500
Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:35010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1aGjgn-0006xV-KQ
	for qemu-devel@nongnu.org; Wed, 06 Jan 2016 03:43:29 -0500
Received: by mail-wm0-x236.google.com with SMTP id f206so51303239wmf.0
	for <qemu-devel@nongnu.org>; Wed, 06 Jan 2016 00:43:28 -0800 (PST)
References: <1450355367-14818-1-git-send-email-eric.auger@linaro.org>
	<1450355367-14818-4-git-send-email-eric.auger@linaro.org>
	<CAFEAcA8L_HSU2s1++2tahzc=UVN1hnUGeKbALf4wd2AL2D4eAw@mail.gmail.com>
	<568BED5B.7030505@linaro.org>
	<CAFEAcA_fCjS=ZAwFD30EsrAyEeHKykBOsQc5DsW=s=veH0cqOQ@mail.gmail.com>
From: Eric Auger <eric.auger@linaro.org>
Message-ID: <568CD3A2.4030807@linaro.org>
Date: Wed, 6 Jan 2016 09:43:14 +0100
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_fCjS=ZAwFD30EsrAyEeHKykBOsQc5DsW=s=veH0cqOQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/6] device_tree: introduce
	qemu_fdt_node_path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Baptiste Reynal <b.reynal@virtualopensystems.com>, Thomas Huth <thuth@redhat.com>, eric.auger@st.com, Patch Tracking <patches@linaro.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Alex Williamson <alex.williamson@redhat.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Paolo Bonzini <pbonzini@redhat.com>, thomas.lendacky@amd.com, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, David Gibson <david@gibson.dropbear.id.au>

On 01/05/2016 06:55 PM, Peter Maydell wrote:
> On 5 January 2016 at 16:20, Eric Auger <eric.auger@linaro.org> wrote:
>> Hi Peter,
>> On 12/18/2015 03:23 PM, Peter Maydell wrote:
>>> On 17 December 2015 at 12:29, Eric Auger <eric.auger@linaro.org> wrote:
>>>> This new helper routine returns the node path of a device
>>>> referred to by its node name and compat string.
>>>>
>>>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> 
>>>> +
>>>> +    *node_path = NULL;
>>>> +    offset = fdt_node_offset_by_compatible(fdt, -1, compat);
>>>> +    while (offset != -FDT_ERR_NOTFOUND) {
>>>> +        if (offset < 0) {
>>>> +            continue;
>>>
>>> I don't understand this continue -- if the fdt function returned any
>>> error other than -FDT_ERR_NOTFOUND then this will cause us to go
>>> into an infinite loop around this while(). Did you mean 'break' ?
>>> (Though if you just want to break then fixing the while condition
>>> would be better.)
>> My first understanding of the API was fdt_node_offset_by_compatible
>> would increment the offset even if an error occurred; so I envisioned to
>> continue parsing the tree, looking for another node with same features.
> 
> Your code doesn't call fdt_node_offset_by_compatible again
> in the case where it's trying to continue, though...

I'll be damned, got it now!

Thanks

Eric
> 
> thanks
> -- PMM
>