* [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code
@ 2016-01-06 12:53 Andrew Jones
2016-01-06 15:54 ` Eric Blake
2016-01-07 11:40 ` Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Jones @ 2016-01-06 12:53 UTC (permalink / raw)
To: qemu-devel; +Cc: edgar.iglesias, crosthwaite.peter, alistair.francis
stream_desc_show() (and DEBUG_ENET) appear to be unused, as the
function isn't compilable (there are broken PRI format strings).
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
hw/dma/xilinx_axidma.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
index b1cfa11356a26..f5ebc1f0e0734 100644
--- a/hw/dma/xilinx_axidma.c
+++ b/hw/dma/xilinx_axidma.c
@@ -177,16 +177,6 @@ static inline int streamid_from_addr(hwaddr addr)
return sid;
}
-#ifdef DEBUG_ENET
-static void stream_desc_show(struct SDesc *d)
-{
- qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address);
- qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc);
- qemu_log("control = %x\n", d->control);
- qemu_log("status = %x\n", d->status);
-}
-#endif
-
static void stream_desc_load(struct Stream *s, hwaddr addr)
{
struct SDesc *d = &s->desc;
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code
2016-01-06 12:53 [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code Andrew Jones
@ 2016-01-06 15:54 ` Eric Blake
2016-01-06 18:25 ` Alistair Francis
2016-01-07 11:40 ` Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Eric Blake @ 2016-01-06 15:54 UTC (permalink / raw)
To: Andrew Jones, qemu-devel
Cc: edgar.iglesias, alistair.francis, crosthwaite.peter
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On 01/06/2016 05:53 AM, Andrew Jones wrote:
> stream_desc_show() (and DEBUG_ENET) appear to be unused, as the
> function isn't compilable (there are broken PRI format strings).
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> hw/dma/xilinx_axidma.c | 10 ----------
> 1 file changed, 10 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code
2016-01-06 15:54 ` Eric Blake
@ 2016-01-06 18:25 ` Alistair Francis
0 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2016-01-06 18:25 UTC (permalink / raw)
To: Eric Blake
Cc: Edgar Iglesias, Andrew Jones, Peter Crosthwaite,
qemu-devel@nongnu.org Developers, Alistair Francis
On Wed, Jan 6, 2016 at 7:54 AM, Eric Blake <eblake@redhat.com> wrote:
> On 01/06/2016 05:53 AM, Andrew Jones wrote:
>> stream_desc_show() (and DEBUG_ENET) appear to be unused, as the
>> function isn't compilable (there are broken PRI format strings).
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> ---
>> hw/dma/xilinx_axidma.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Thanks,
Alistair
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code
2016-01-06 12:53 [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code Andrew Jones
2016-01-06 15:54 ` Eric Blake
@ 2016-01-07 11:40 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-01-07 11:40 UTC (permalink / raw)
To: Andrew Jones
Cc: Edgar E. Iglesias, Alistair Francis, QEMU Developers,
Peter Crosthwaite
On 6 January 2016 at 12:53, Andrew Jones <drjones@redhat.com> wrote:
> stream_desc_show() (and DEBUG_ENET) appear to be unused, as the
> function isn't compilable (there are broken PRI format strings).
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> hw/dma/xilinx_axidma.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index b1cfa11356a26..f5ebc1f0e0734 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -177,16 +177,6 @@ static inline int streamid_from_addr(hwaddr addr)
> return sid;
> }
>
> -#ifdef DEBUG_ENET
> -static void stream_desc_show(struct SDesc *d)
> -{
> - qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address);
> - qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc);
> - qemu_log("control = %x\n", d->control);
> - qemu_log("status = %x\n", d->status);
> -}
> -#endif
> -
> static void stream_desc_load(struct Stream *s, hwaddr addr)
> {
> struct SDesc *d = &s->desc;
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-07 11:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 12:53 [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code Andrew Jones
2016-01-06 15:54 ` Eric Blake
2016-01-06 18:25 ` Alistair Francis
2016-01-07 11:40 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).