From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGqws-0007zp-2O for qemu-devel@nongnu.org; Wed, 06 Jan 2016 11:28:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGqwo-0001HP-1B for qemu-devel@nongnu.org; Wed, 06 Jan 2016 11:28:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGqwn-0001H5-SB for qemu-devel@nongnu.org; Wed, 06 Jan 2016 11:28:29 -0500 References: <6ca84848.f052.15211b20317.Coremail.magazine.lihuiba@163.com> <568BCB6C.7010709@redhat.com> <557a47a5.3564.15214d76e2e.Coremail.magazine.lihuiba@163.com> <568D2D00.3050600@redhat.com> <568D3EDD.1090205@redhat.com> From: Eric Blake Message-ID: <568D40AC.5050901@redhat.com> Date: Wed, 6 Jan 2016 09:28:28 -0700 MIME-Version: 1.0 In-Reply-To: <568D3EDD.1090205@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ixGlXb122nXqV7Uh7DLtJjG9oECkNwxn0" Subject: Re: [Qemu-devel] qcow2 snapshot + resize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , lihuiba Cc: "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ixGlXb122nXqV7Uh7DLtJjG9oECkNwxn0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/06/2016 09:20 AM, Max Reitz wrote: >> If I take a snapshot while the guest sees a 1G disk, then resize the >> disk to 2G, then roll back to the point in time of the snapshot, I'd >> expect the disk to roll back to 1G in size. Anything else is likely t= o >> confuse the guest. And that's what current resize support already doe= s >> (it only resizes the active image, not the snapshots). >=20 > No, the current resize operation just refuses to resize the image if it= > has any snapshots. Snapshots currently do not store the size of the > image when they were created. Huh? I thought that we specifically added bytes 48-55 per snapshot entry in the qcow2v3 description specifically so that internal snapshots DO record the size of the image when the snapshot was created. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ixGlXb122nXqV7Uh7DLtJjG9oECkNwxn0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWjUCsAAoJEKeha0olJ0Nqbq8IAIxJmgEcYg2V0nNQfQyhRCGa dkM4wYLvVAagCaZFG6hEkMoytehB51BbFIRaF55fL/yl2xga6qgaVt3yhFUOXTOe xMvxAZ7WLuKSb9j03UGIKFQklwJJPHMODyhJzZ/ohdJfptH7WNCT5G+zTq62Itos 1akbcIf2G5Xm+ULg8XU/OG7TFgaIY53Z9451ZbkiDHkqdu7fNGDMEDB8ZtRBwZ/m +YtO1ChJ0jpRC5WeCzh0SL7b7ddWO8RtP5rCEhQg9Nh5kGNoCTLyR9csq54ZqROC rMk15X/JznLQjzmS3OHDL2mJLWV/N/zhuW0Kh+ElwkIB9/EwJw2xWet1yO0m7lk= =1RlM -----END PGP SIGNATURE----- --ixGlXb122nXqV7Uh7DLtJjG9oECkNwxn0--