From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGv9J-0001X5-3j for qemu-devel@nongnu.org; Wed, 06 Jan 2016 15:57:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGv9E-0003tb-0c for qemu-devel@nongnu.org; Wed, 06 Jan 2016 15:57:41 -0500 References: <1452112646-15969-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1452112646-15969-3-git-send-email-mark.cave-ayland@ilande.co.uk> From: John Snow Message-ID: <568D7FBC.1000505@redhat.com> Date: Wed, 6 Jan 2016 15:57:32 -0500 MIME-Version: 1.0 In-Reply-To: <1452112646-15969-3-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] macio: add dma_active to VMStateDescription List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de Cc: Stefan Hajnoczi On 01/06/2016 03:37 PM, Mark Cave-Ayland wrote: > Make sure that we include the value of dma_active in the migration stream. > > Signed-off-by: Mark Cave-Ayland > --- > hw/ide/macio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/ide/macio.c b/hw/ide/macio.c > index 560c071..695d4d2 100644 > --- a/hw/ide/macio.c > +++ b/hw/ide/macio.c > @@ -518,11 +518,12 @@ static const MemoryRegionOps pmac_ide_ops = { > > static const VMStateDescription vmstate_pmac = { > .name = "ide", > - .version_id = 3, > + .version_id = 4, > .minimum_version_id = 0, > .fields = (VMStateField[]) { > VMSTATE_IDE_BUS(bus, MACIOIDEState), > VMSTATE_IDE_DRIVES(bus.ifs, MACIOIDEState), > + VMSTATE_BOOL(dma_active, MACIOIDEState), > VMSTATE_END_OF_LIST() > } > }; > Did you wind up ever observing this value to be non-zero when it was written to the migration stream? I really did think that we should be able to assume this was always false due to how migration will drain all outstanding AIO, but maybe I am mistaken. --js