From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga()
Date: Thu, 7 Jan 2016 11:26:03 +0800 [thread overview]
Message-ID: <568DDACB.1010103@cn.fujitsu.com> (raw)
In-Reply-To: <568D3874.1060806@redhat.com>
On 01/06/2016 11:53 PM, Eric Blake wrote:
> On 01/05/2016 07:39 PM, Cao jin wrote:
[...]
>
> Please no '!' in error messages. We aren't shouting at the user.
Interesting, I didn`t think of this kind of questions before. will fix
>
>> XEN_PT_ERR(d, "Setup VGA BIOS of passthrough GFX failed!\n");
>
> Do we still need the XEN_PT_ERR() alongside setting the local error?
>
this is fixed in "4/4 convert to realize" patch, as I said in last mail,
I try to make every patch as small as possible
>> xen_host_pci_device_put(&s->real_device);
>> return -1;
>
> This leaks local_err.
>
>
[...]
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-01-07 3:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 2:39 [Qemu-devel] [PATCH v3 0/4] Convert to realize() Cao jin
2016-01-06 2:39 ` [Qemu-devel] [PATCH v3 1/4] Add Error **errp for xen_host_pci_device_get() Cao jin
2016-01-06 15:51 ` Eric Blake
2016-01-07 3:13 ` Cao jin
2016-01-07 16:47 ` Eric Blake
2016-01-06 2:39 ` [Qemu-devel] [PATCH v3 2/4] Add Error **errp for xen_pt_setup_vga() Cao jin
2016-01-06 15:53 ` Eric Blake
2016-01-07 3:26 ` Cao jin [this message]
2016-01-06 2:39 ` [Qemu-devel] [PATCH v3 3/4] Add Error **errp for xen_pt_config_init() Cao jin
2016-01-06 16:02 ` Eric Blake
2016-01-07 8:12 ` Cao jin
2016-01-07 16:51 ` Eric Blake
2016-01-08 8:41 ` Cao jin
2016-01-06 2:39 ` [Qemu-devel] [PATCH v3 4/4] Xen PCI passthru: convert to realize() Cao jin
2016-01-06 16:07 ` Eric Blake
2016-01-07 7:16 ` Cao jin
2016-01-07 16:53 ` Eric Blake
2016-01-06 11:08 ` [Qemu-devel] [PATCH v3 0/4] Convert " Stefano Stabellini
2016-01-06 15:51 ` Eric Blake
2016-01-06 16:02 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568DDACB.1010103@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).