From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, Zhu Lingshan <lszhu@suse.com>
Cc: Peter Lieven <pl@kamp.de>,
qemu-block@nongnu.org, ronnie sahlberg <ronniesahlberg@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] send readcapacity10 when readcapacity16 failed
Date: Thu, 7 Jan 2016 11:07:58 +0100 [thread overview]
Message-ID: <568E38FE.1080408@redhat.com> (raw)
In-Reply-To: <568D556D.2090408@redhat.com>
On 06/01/2016 18:57, John Snow wrote:
> Ronnie: Thanks for the explanation!
>
> Zhu: In light of this, can the patch be reworked slightly to explicitly
> check *why* READCAPACITY16 failed and only attempt the READCAPACITY10 as
> a fallback if it receives INVALID_OPCODE?
>
> If it fails for any other reason it's probably best to report the error
> and let QEMU decide what to do about it.
Any other failure probably would happen for READ CAPACITY(10) as well, so
it's okay to ignore it for READ CAPACITY(16).
Zhu's patch matches what Linux does by default, it seems okay. The only
change needed is to retry READ CAPACITY(16) if there is a UNIT ATTENTION
sense:
+ if (task != NULL && task->status == SCSI_STATUS_CHECK_CONDITION
+ && task->sense.key == SCSI_SENSE_UNIT_ATTENTION) {
+ break;
+ }
Paolo
next prev parent reply other threads:[~2016-01-07 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 3:32 [Qemu-devel] [PATCH] send readcapacity10 when readcapacity16 failed Zhu Lingshan
2016-01-05 19:42 ` [Qemu-devel] [Qemu-block] " John Snow
2016-01-05 19:57 ` ronnie sahlberg
2016-01-06 17:57 ` John Snow
2016-01-07 10:07 ` Paolo Bonzini [this message]
2016-01-11 8:49 ` Peter Lieven
2016-01-11 9:46 ` Paolo Bonzini
2016-01-07 10:08 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E38FE.1080408@redhat.com \
--to=pbonzini@redhat.com \
--cc=jsnow@redhat.com \
--cc=lszhu@suse.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).