From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48828)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aH9rS-00088G-7C
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 07:40:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aH9rP-0001HK-12
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 07:40:14 -0500
Received: from mx2.parallels.com ([199.115.105.18]:36598)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aH9rO-0001H9-Qz
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 07:40:10 -0500
References: <1446151457-21157-1-git-send-email-den@openvz.org>
	<20160107095856.GA17701@stefanha-x1.localdomain>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <568E5CA1.2050303@openvz.org>
Date: Thu, 7 Jan 2016 15:40:01 +0300
MIME-Version: 1.0
In-Reply-To: <20160107095856.GA17701@stefanha-x1.localdomain>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints,
 and connect them to logging
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 01/07/2016 12:58 PM, Stefan Hajnoczi wrote:

[skipped]

> 3.
> I also now get a handful of extra warnings in the 'make check' output:
>
>    /aarch64/qom/xilinx-zynq-a9:                                         OK
>    /aarch64/qom/xlnx-ep108:
> WARNING: RAM size 8000000 is small for EP108OK
I do not observe this problem.

>    /aarch64/qom/vexpress-a9:                                            OK
>
> (note the missing newline...)
>
> TEST: tests/qom-test... (pid=19738)
>    /microblaze/qom/none:                                                OK
>    /microblaze/qom/petalogix-s3adsp1800:
> Invalid MicroBlaze version number: (null)
> OK
>    /microblaze/qom/petalogix-ml605:
> Invalid MicroBlaze version number: (null)
> OK
This problem exists in the original code.
The patchset just reveals something hidden.

This patch aborts() on unmodified sources.
Edgar, do you have any opinion?

Den

diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
index 52959e1..fae8ef6 100644
--- a/target-microblaze/cpu.c
+++ b/target-microblaze/cpu.c
@@ -167,6 +167,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error 
**errp)

      if (!version_code) {
          qemu_log("Invalid MicroBlaze version number: %s\n", 
cpu->cfg.version);
+        abort();
      }

      env->pvr.regs[0] |= (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) |