From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] qemu-char: add logfile facility to all chardev backends
Date: Thu, 7 Jan 2016 14:08:08 +0100 [thread overview]
Message-ID: <568E6338.4080407@redhat.com> (raw)
In-Reply-To: <568E3E82.5020300@redhat.com>
On 07/01/2016 11:31, Paolo Bonzini wrote:
>
>
> On 23/12/2015 14:27, Daniel P. Berrange wrote:
>> - mon_chr = qemu_chr_alloc();
>> + mon_chr = qemu_chr_alloc(&common, NULL);
>
> Changed NULL to &error_abort, and queued.
Hmm, nope... this is missing documentation of the new options (though it
does mention them in the help). Can you add it for v4?
Paolo
> Paolo
>
>> mon_chr->chr_write = gdb_monitor_write;
>
>
prev parent reply other threads:[~2016-01-07 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 13:27 [Qemu-devel] [PATCH v3] qemu-char: add logfile facility to all chardev backends Daniel P. Berrange
2016-01-07 10:31 ` Paolo Bonzini
2016-01-07 13:08 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E6338.4080407@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).