From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHCNZ-0004v3-9D
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:21:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHCNT-00068k-CU
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:21:33 -0500
Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:33044)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHCNT-00068b-5k
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:21:27 -0500
Received: by mail-wm0-x22e.google.com with SMTP id f206so101929906wmf.0
	for <qemu-devel@nongnu.org>; Thu, 07 Jan 2016 07:21:27 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1449749584-23214-1-git-send-email-frankja@linux.vnet.ibm.com>
	<1449749584-23214-21-git-send-email-frankja@linux.vnet.ibm.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <568E8274.7010102@redhat.com>
Date: Thu, 7 Jan 2016 16:21:24 +0100
MIME-Version: 1.0
In-Reply-To: <1449749584-23214-21-git-send-email-frankja@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 20/34] scripts/kvm/kvm_stat: Cleanup cpu
	list retrieval
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Janosch Frank <frankja@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com



On 10/12/2015 13:12, Janosch Frank wrote:
> +    with open('/sys/devices/system/cpu/online') as cpu_list:
> +        cpu_string = cpu_list.readline()
> +        cpus = cpu_string.split(',')
> +
> +        for cpu in cpus:
> +            if '-' not in cpu:
> +                cpulist.append(int(cpu))
> +            else:
> +                cpu_range = cpu.split('-')
> +                cpulist.extend(range(int(cpu_range[0]),
> +                                     int(cpu_range[1]) + 1))

Perhaps you can move everything after readline() to a separate function?

Paolo