From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHCRl-0007jc-HF for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:25:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHCRg-0007QX-Hg for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:25:53 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:38403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHCRg-0007QR-BI for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:25:48 -0500 Received: by mail-wm0-x230.google.com with SMTP id b14so128824710wmb.1 for ; Thu, 07 Jan 2016 07:25:48 -0800 (PST) Sender: Paolo Bonzini References: <1449749584-23214-1-git-send-email-frankja@linux.vnet.ibm.com> <1449749584-23214-25-git-send-email-frankja@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <568E8379.4040001@redhat.com> Date: Thu, 7 Jan 2016 16:25:45 +0100 MIME-Version: 1.0 In-Reply-To: <1449749584-23214-25-git-send-email-frankja@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 24/34] scripts/kvm/kvm_stat: Cleanup of Event class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Janosch Frank , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com On 10/12/2015 13:12, Janosch Frank wrote: > + event_data = { > + 'cpu': cpu, > + 'name': name, > + 'group': group, > + 'set': 'kvm', > + 'tracepoint': tracepoint, > + 'filter': tracefilter or None, > + } > + group.add_event(event_data) I'd rather have the Event passed directly to add_event, and the event constructor use keyword arguments instead of a dictionary. Paolo > self.group_leaders.append(group)