From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHCjb-0003kN-OE for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:44:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHCjX-0003zc-OA for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:44:19 -0500 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:38903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHCjX-0003zQ-IA for qemu-devel@nongnu.org; Thu, 07 Jan 2016 10:44:15 -0500 Received: by mail-wm0-x229.google.com with SMTP id b14so129719183wmb.1 for ; Thu, 07 Jan 2016 07:44:15 -0800 (PST) Sender: Paolo Bonzini References: <1449749584-23214-1-git-send-email-frankja@linux.vnet.ibm.com> <20151215105635.2a9ea70c.cornelia.huck@de.ibm.com> <20160107144142.7a7556a3.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <568E87CA.5070308@redhat.com> Date: Thu, 7 Jan 2016 16:44:10 +0100 MIME-Version: 1.0 In-Reply-To: <20160107144142.7a7556a3.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/34] kvm_stat: Cleanup and fixup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , qemu-devel@nongnu.org Cc: Janosch Frank On 07/01/2016 14:41, Cornelia Huck wrote: > On Tue, 15 Dec 2015 10:56:35 +0100 > Cornelia Huck wrote: > >> On Thu, 10 Dec 2015 13:12:30 +0100 >> Janosch Frank wrote: >> >>> Kvm_stat is a very helpful script for checking the state of VMs, but >>> when I tried to introduce new features it broke every few lines. >>> >>> This patch series aims to make the script more readable and durable, >>> so future additions to it will break it less likely. It also fixes >>> input/output problems for all of its interface modes. >>> >>> Testing was done rarely on X86_64 RHEL 6.7 and mostly on s390. Tests >>> on other architectures would be beneficial. >> >> The cleanup and fixes look good to me, but I'm most certainly not a >> python expert :) >> >> Paolo, would you take these through the kvm tree? > > Anybody interested in these? I can't really comment on python stuff, > but it would be a shame if these patches were left out in the cold... Ok, I've now reviewed it. I didn't have many comments, but the Signed-off-by was missing so I prefer to have a v2 instead of follow-up patches. Paolo