From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aHDWh-0002Bj-PC
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:35:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aHDWe-0003Rx-Fq
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:35:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43208)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aHDWe-0003Rn-9l
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:35:00 -0500
References: <1450870121-15943-1-git-send-email-asmetanin@virtuozzo.com>
	<1450870121-15943-4-git-send-email-asmetanin@virtuozzo.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <568E93AE.1050401@redhat.com>
Date: Thu, 7 Jan 2016 17:34:54 +0100
MIME-Version: 1.0
In-Reply-To: <1450870121-15943-4-git-send-email-asmetanin@virtuozzo.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 3/6] kvm/x86: Reorg stimer_expiration()
 to better control timer restart
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrey Smetanin <asmetanin@virtuozzo.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>, "Denis V. Lunev" <den@openvz.org>, Roman Kagan <rkagan@virtuozzo.com>, qemu-devel@nongnu.org



On 23/12/2015 12:28, Andrey Smetanin wrote:
> -	stimer_send_msg(stimer);
> -	if (!(stimer->config & HV_STIMER_PERIODIC))
> -		stimer->config |= ~HV_STIMER_ENABLE;
> -	else
> -		stimer_start(stimer);
> +	stimer->msg_pending = true;
> +	if (!stimer_send_msg(stimer)) {
> +		stimer->msg_pending = false;
> +		if (!(stimer->config & HV_STIMER_PERIODIC))
> +			stimer->config |= ~HV_STIMER_ENABLE;

Just because this is curious: sure it shouldn't be "&="?

Paolo

> +	}