From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aHDtZ-00041q-5r
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:58:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aHDtW-0002m7-FL
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:58:41 -0500
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:46727)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aHDtW-0002lx-61
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:58:38 -0500
Received: from localhost
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <frankja@linux.vnet.ibm.com>;
	Thu, 7 Jan 2016 16:58:36 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5AF83219004D
	for <qemu-devel@nongnu.org>; Thu,  7 Jan 2016 16:58:23 +0000 (GMT)
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u07GwX8B9306616
	for <qemu-devel@nongnu.org>; Thu, 7 Jan 2016 16:58:33 GMT
Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u07GwXpH018395
	for <qemu-devel@nongnu.org>; Thu, 7 Jan 2016 09:58:33 -0700
References: <1449749584-23214-1-git-send-email-frankja@linux.vnet.ibm.com>
	<1449749584-23214-8-git-send-email-frankja@linux.vnet.ibm.com>
	<568E7C87.1060700@redhat.com>
From: Janosch Frank <frankja@linux.vnet.ibm.com>
Message-ID: <568E9939.7040001@linux.vnet.ibm.com>
Date: Thu, 7 Jan 2016 17:58:33 +0100
MIME-Version: 1.0
In-Reply-To: <568E7C87.1060700@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/34] scripts/kvm/kvm_stat: Cleanup of
	path variables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com

On 01/07/2016 03:56 PM, Paolo Bonzini wrote:
> 
> 
> On 10/12/2015 13:12, Janosch Frank wrote:
>>  if not os.access('/sys/kernel/debug', os.F_OK):
> 
> PATH_DEBUGFS should be /sys/kernel/debug, while...
> 
>>      print 'Please enable CONFIG_DEBUG_FS in your kernel'
>>      sys.exit(1)
>> -if not os.access('/sys/kernel/debug/kvm', os.F_OK):
>> +if not os.access(PATH_DEBUGFS, os.F_OK):
> 
> ... this should be PATH_DEBUGFS_KVM.
> 
> Paolo
> 
Sure, when I'm at it I'll also change PATH_TRACING to
PATH_DEBUGFS_TRACING so they are consistent.