From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDxG-0001Uv-9Y for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:02:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDxC-0004Kb-4J for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:02:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDxB-0004KW-Ve for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:02:26 -0500 References: <1449749584-23214-1-git-send-email-frankja@linux.vnet.ibm.com> <1449749584-23214-21-git-send-email-frankja@linux.vnet.ibm.com> <568E8274.7010102@redhat.com> <568E98BB.1080707@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <568E9A1B.4010506@redhat.com> Date: Thu, 7 Jan 2016 18:02:19 +0100 MIME-Version: 1.0 In-Reply-To: <568E98BB.1080707@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 20/34] scripts/kvm/kvm_stat: Cleanup cpu list retrieval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Janosch Frank , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com On 07/01/2016 17:56, Janosch Frank wrote: > The string analysis to extract the cpu numbers is only needed in the > get_online_cpus function where it resides, so why do you want to split > this function into two? > > Its also only a few lines which are easy to read. It's a common format in sysfs, so it is not implausible that it will be reused. The function could be named parse_int_list. Paolo