From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37675)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1aHESB-0003lS-Pu
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:34:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1aHESA-0005Ew-Vj
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:34:27 -0500
References: <cover.1451960508.git.digetx@gmail.com>
	<c4dafbd33c4428495d20d9b2228033ed5868b63b.1451960508.git.digetx@gmail.com>
	<20160106131744.GE4227@pcrost-box>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <568EA189.8080804@gmail.com>
Date: Thu, 7 Jan 2016 20:34:01 +0300
MIME-Version: 1.0
In-Reply-To: <20160106131744.GE4227@pcrost-box>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v8 4/4] arm_mptimer: Convert to use ptimer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org, QEMU Developers <qemu-devel@nongnu.org>

06.01.2016 16:17, Peter Crosthwaite пишет:
>> +        if ((old & 3) != (tb->control & 3)) {
>> +            ptimer_stop(tb->timer);
>> +        }
>> +        if (!(tb->control & 1)) {
>> +            break;
>> +        }
>> +        ptimer_set_period(tb->timer, timerblock_scale(tb));
>> +        if ((old & 3) != (tb->control & 3)) {
>> +            value = ptimer_get_count(tb->timer);
>> +            timerblock_run(tb, value, 1);
>
> Is this reachable when the load value is still 0?
>

Yes, timer runs based on current counter value. You can load = 0 and set counter 
!= 0 that would result in one-shot tick. Hmm... I need to fix it. Thanks for 
leading question!

Ughh... just noticed that test_timer_set_oneshot_count_to_0() on real HW sets IT 
bit if prescaler != 0. Looking into it..

-- 
Dmitry