From: Laurent Vivier <lvivier@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper
Date: Thu, 7 Jan 2016 20:55:50 +0100 [thread overview]
Message-ID: <568EC2C6.2020604@redhat.com> (raw)
In-Reply-To: <20160107113214.10897.50820.stgit@bahia.huguette.org>
On 07/01/2016 12:32, Greg Kurz wrote:
> It is not used anymore.
>
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> include/hw/virtio/virtio-access.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h
> index 8aec843c8ff3..a01fff2e51d7 100644
> --- a/include/hw/virtio/virtio-access.h
> +++ b/include/hw/virtio/virtio-access.h
> @@ -143,15 +143,6 @@ static inline uint64_t virtio_ldq_p(VirtIODevice *vdev, const void *ptr)
> }
> }
>
> -static inline bool virtio_needs_swap(VirtIODevice *vdev)
> -{
> -#ifdef HOST_WORDS_BIGENDIAN
> - return virtio_access_is_big_endian(vdev) ? false : true;
> -#else
> - return virtio_access_is_big_endian(vdev) ? true : false;
> -#endif
> -}
> -
I think you can move this to PATCH 1/6 too.
> static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s)
> {
> #ifdef HOST_WORDS_BIGENDIAN
>
>
next prev parent reply other threads:[~2016-01-07 19:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 11:31 [Qemu-devel] [PATCH 0/6] virtio/vhost cross-endian cleanup Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 1/6] virtio-net: use the backend cross-endian capabilities Greg Kurz
2016-01-07 16:22 ` Laurent Vivier
2016-01-07 17:23 ` Greg Kurz
2016-01-07 18:32 ` Laurent Vivier
2016-01-08 14:19 ` Greg Kurz
2016-01-08 15:25 ` Laurent Vivier
2016-01-08 16:00 ` Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 2/6] Revert "vhost-net: tell tap backend about the vnet endianness" Greg Kurz
2016-01-07 19:52 ` Laurent Vivier
2016-01-08 9:07 ` Greg Kurz
2016-01-08 10:11 ` Cornelia Huck
2016-01-08 10:26 ` Greg Kurz
2016-01-08 11:09 ` Cornelia Huck
2016-01-07 11:32 ` [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper Greg Kurz
2016-01-07 19:55 ` Laurent Vivier [this message]
2016-01-08 9:16 ` Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 4/6] virtio: move cross-endian helper to vhost Greg Kurz
2016-01-07 11:32 ` [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper Greg Kurz
2016-01-07 20:07 ` Laurent Vivier
2016-01-08 9:21 ` Greg Kurz
2016-01-08 10:07 ` Cornelia Huck
2016-01-08 10:22 ` Laurent Vivier
2016-01-07 11:32 ` [Qemu-devel] [PATCH 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets Greg Kurz
2016-01-07 20:25 ` Laurent Vivier
2016-01-08 9:27 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EC2C6.2020604@redhat.com \
--to=lvivier@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).