From: Andrey Smetanin <asmetanin@virtuozzo.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>, "Denis V. Lunev" <den@openvz.org>,
Roman Kagan <rkagan@virtuozzo.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 3/6] kvm/x86: Reorg stimer_expiration() to better control timer restart
Date: Thu, 7 Jan 2016 23:13:35 +0300 [thread overview]
Message-ID: <568EC6EF.90102@virtuozzo.com> (raw)
In-Reply-To: <568E93AE.1050401@redhat.com>
On 01/07/2016 07:34 PM, Paolo Bonzini wrote:
>
>
> On 23/12/2015 12:28, Andrey Smetanin wrote:
>> - stimer_send_msg(stimer);
>> - if (!(stimer->config & HV_STIMER_PERIODIC))
>> - stimer->config |= ~HV_STIMER_ENABLE;
>> - else
>> - stimer_start(stimer);
>> + stimer->msg_pending = true;
>> + if (!stimer_send_msg(stimer)) {
>> + stimer->msg_pending = false;
>> + if (!(stimer->config & HV_STIMER_PERIODIC))
>> + stimer->config |= ~HV_STIMER_ENABLE;
>
> Just because this is curious: sure it shouldn't be "&="?
You are right, we found it too late - only by testing Linux guest
Hyper-v timers which are one-shot timers. We have fixed it in v2.
>
> Paolo
>
>> + }
next prev parent reply other threads:[~2016-01-07 20:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 11:28 [Qemu-devel] [PATCH v1 0/6] KVM: Hyper-V SynIC timers migration fixes Andrey Smetanin
2015-12-23 11:28 ` [Qemu-devel] [PATCH v1 1/6] kvm/x86: Drop stimer_stop() function Andrey Smetanin
2015-12-23 11:28 ` [Qemu-devel] [PATCH v1 2/6] kvm/x86: Hyper-V unify stimer_start() and stimer_restart() Andrey Smetanin
2016-01-07 16:32 ` Paolo Bonzini
2016-01-07 21:02 ` Andrey Smetanin
2015-12-23 11:28 ` [Qemu-devel] [PATCH v1 3/6] kvm/x86: Reorg stimer_expiration() to better control timer restart Andrey Smetanin
2016-01-07 16:34 ` Paolo Bonzini
2016-01-07 20:13 ` Andrey Smetanin [this message]
2015-12-23 11:28 ` [Qemu-devel] [PATCH v1 4/6] kvm/x86: Hyper-V fix SynIC timer disabling condition Andrey Smetanin
2015-12-23 11:28 ` [Qemu-devel] [PATCH v1 5/6] kvm/x86: Skip SynIC vector check for QEMU side Andrey Smetanin
2015-12-23 11:28 ` [Qemu-devel] [PATCH v1 6/6] kvm/x86: Update SynIC timers on guest entry only Andrey Smetanin
2016-01-07 16:38 ` [Qemu-devel] [PATCH v1 0/6] KVM: Hyper-V SynIC timers migration fixes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568EC6EF.90102@virtuozzo.com \
--to=asmetanin@virtuozzo.com \
--cc=den@openvz.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).