From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHOMC-0007o9-SL for qemu-devel@nongnu.org; Thu, 07 Jan 2016 23:08:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHOM9-0002Rh-MN for qemu-devel@nongnu.org; Thu, 07 Jan 2016 23:08:56 -0500 Received: from mga11.intel.com ([192.55.52.93]:20839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHOM9-0002Rd-GW for qemu-devel@nongnu.org; Thu, 07 Jan 2016 23:08:53 -0500 References: <1451933528-133684-1-git-send-email-guangrong.xiao@linux.intel.com> <1451933528-133684-6-git-send-email-guangrong.xiao@linux.intel.com> <20160107152228.2676222a@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: <568F34B2.9090101@linux.intel.com> Date: Fri, 8 Jan 2016 12:01:54 +0800 MIME-Version: 1.0 In-Reply-To: <20160107152228.2676222a@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On 01/07/2016 10:22 PM, Igor Mammedov wrote: > On Tue, 5 Jan 2016 02:52:07 +0800 > Xiao Guangrong wrote: > >> If dsm memory is successfully patched, we let qemu fully emulate >> the dsm method >> >> This patch saves _DSM input parameters into dsm memory, tell dsm >> memory address to QEMU, then fetch the result from the dsm memory > you also need to add NVDR._CRS method that would report > resources used by operation regions. I can not understand this point, why we need to report the resource of OperationRegion? It is ACPI internally used anyway. > > NVDIMM_COMMON_DSM - probably should be serialized, otherwise > there is a race risk, when several callers would write to > control region. Yes, i did it in patch 6/6, but definitely i should more it to here.