From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSvw-0004Hq-Qt
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:02:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSvt-0004Bw-JM
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:02:08 -0500
Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:32915)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSvt-0004Bd-D6
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:02:05 -0500
Received: by mail-wm0-x230.google.com with SMTP id f206so127749719wmf.0
	for <qemu-devel@nongnu.org>; Fri, 08 Jan 2016 01:02:05 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450803119-4223-1-git-send-email-mst@redhat.com>
	<1450803119-4223-15-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <568F7B0A.3080705@redhat.com>
Date: Fri, 8 Jan 2016 10:02:02 +0100
MIME-Version: 1.0
In-Reply-To: <1450803119-4223-15-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Corey Minyard <cminyard@mvista.com>, Xiao Guangrong <guangrong.xiao@linux.intel.com>, Stefan Hajnoczi <stefanha@redhat.com>, Shannon Zhao <zhaoshenglong@huawei.com>



On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +    case IPMI_BMC_WATCHDOG_PRE_NMI:
> +        if (!k->do_hw_op(s, IPMI_SEND_NMI, 1)) {
> +            /* NMI not supported. */
> +            rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> +            goto out;
> +        }
> +    default:
> +        /* We don't support PRE_SMI */
> +        rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> +        goto out;

Hi Michael and Corey,

Coverity here complains that the "case IPMI_BMC_WATCHDOG_PRE_NMI" falls
through to the default case.  If anything, you could negate the "if"
condition and then it would make sense to fall through; but given how
the code is written, I think Coverity is correct.

Thanks,

Paolo