From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSzY-0006bM-Dk
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:05:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSzT-0005ti-2p
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:05:52 -0500
Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:37147)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSzS-0005tc-Rz
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:05:46 -0500
Received: by mail-wm0-x231.google.com with SMTP id f206so161135117wmf.0
	for <qemu-devel@nongnu.org>; Fri, 08 Jan 2016 01:05:46 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450803119-4223-1-git-send-email-mst@redhat.com>
	<1450803119-4223-15-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <568F7BE8.9060505@redhat.com>
Date: Fri, 8 Jan 2016 10:05:44 +0100
MIME-Version: 1.0
In-Reply-To: <1450803119-4223-15-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Corey Minyard <cminyard@mvista.com>, Xiao Guangrong <guangrong.xiao@linux.intel.com>, Stefan Hajnoczi <stefanha@redhat.com>, Shannon Zhao <zhaoshenglong@huawei.com>



On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +{
> +    if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {

Off by one.  The check should be >=, not >.

Paolo

> +        return -1;
> +    }