From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUBf-0008HG-Vx for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:22:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHUBc-0004HD-J4 for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:22:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUBc-0004H4-De for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:22:24 -0500 References: <20160107110747.10897.41118.stgit@bahia.huguette.org> <20160107113226.10897.23886.stgit@bahia.huguette.org> <568EC57E.1010002@redhat.com> <20160108102140.0398ed37@bahia.local> <20160108110738.7db971fe.cornelia.huck@de.ibm.com> From: Laurent Vivier Message-ID: <568F8DDD.4020209@redhat.com> Date: Fri, 8 Jan 2016 11:22:21 +0100 MIME-Version: 1.0 In-Reply-To: <20160108110738.7db971fe.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Greg Kurz Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 08/01/2016 11:07, Cornelia Huck wrote: > On Fri, 8 Jan 2016 10:21:40 +0100 > Greg Kurz wrote: > >> On Thu, 7 Jan 2016 21:07:26 +0100 >> Laurent Vivier wrote: > >>> IMHO, I think 4/6 and 5/6 can be merged as there is no change in the >>> behavior and they are only consolidating code. >>> >> >> Maybe but I'm not sure it is really needed to help acceptance. >> FWIW Cornelia already reviewed both patches. > > I'd keep the two patches separate, as each is easier to understand on > its own IMO. > Ok, no problem. Laurent