From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHW6m-0008Pd-RS for qemu-devel@nongnu.org; Fri, 08 Jan 2016 07:25:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHW6i-0007UG-Lh for qemu-devel@nongnu.org; Fri, 08 Jan 2016 07:25:32 -0500 Received: from mx2.parallels.com ([199.115.105.18]:33217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHW6i-0007UB-G4 for qemu-devel@nongnu.org; Fri, 08 Jan 2016 07:25:28 -0500 References: <1450767586-28794-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <568FAAAF.7040102@openvz.org> Date: Fri, 8 Jan 2016 15:25:19 +0300 MIME-Version: 1.0 In-Reply-To: <1450767586-28794-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org On 12/22/2015 09:59 AM, Denis V. Lunev wrote: > error: Failed to start domain rhel7 > error: internal error: process exited while connecting to monitor: > 2015-12-22T06:55:18.812637Z qemu-system-x86_64: > -drive file=/var/lib/libvirt/images/rhel7.qcow2,if=none, > id=drive-scsi0-0-0-0,format=qcow2,cache=none,aio=native: > aio=native was specified, but it requires cache.direct=on, > which was not specified. > > cache=none option was specified as seen above while the VM is unable to > start. The patch properly passed BDRV_O_NOCACHE to underlying layer. > > The problem is revealed with > commit d657c0c289e944fc22289f5c318f48da87d79dcb > Author: Kevin Wolf > Date: Tue Dec 15 11:35:36 2015 +0100 > > raw-posix: Make aio=native option binding > > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > --- > block.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block.c b/block.c > index 411edbf..fe0fbbc 100644 > --- a/block.c > +++ b/block.c > @@ -990,6 +990,7 @@ static int bdrv_open_common(BlockDriverState *bs, BdrvChild *file, > bs->opaque = g_malloc0(drv->instance_size); > > /* Apply cache mode options */ > + update_flags_from_options(&open_flags, opts); > update_flags_from_options(&bs->open_flags, opts); > bdrv_set_enable_write_cache(bs, bs->open_flags & BDRV_O_CACHE_WB); > ping