From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHXgM-0000cV-HT for qemu-devel@nongnu.org; Fri, 08 Jan 2016 09:06:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHXgI-0004im-HH for qemu-devel@nongnu.org; Fri, 08 Jan 2016 09:06:22 -0500 Received: from mx2.parallels.com ([199.115.105.18]:42793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHXgI-0004i6-Bj for qemu-devel@nongnu.org; Fri, 08 Jan 2016 09:06:18 -0500 References: <1452261610-4039-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <568FC250.8090406@openvz.org> Date: Fri, 8 Jan 2016 17:06:08 +0300 MIME-Version: 1.0 In-Reply-To: <1452261610-4039-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/5] QMP wrappers for VM snapshot operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Shah , Markus Armbruster , qemu-devel@nongnu.org, Juan Quintela On 01/08/2016 05:00 PM, Denis V. Lunev wrote: > EFI based VM with pflash storage for NVRAM could not be snapshoted as > libvirt configures storage as 'raw' and writable. OK, this is a libvirt > problem. > > Another problem is that libvirt can not detect this failure at all > as it uses HMP for this operation. This create snapshot/delete snapshot > sequence passes silently. > > The patchset adds QMP wrappers for the purpose. > > Signed-off-by: "Denis V. Lunev" > CC: Juan Quintela > CC: Amit Shah > CC: Markus Armbruster > CC: Eric Blake > > Changes from v2: > - patches 1/2 are resplit to move processing HMP specific handling > of snapshot name generation to exclusive HMP code > - removed all '.' at the end of error_setg strings > - fixed too long lines with '-' in qmp-commands.hx > - error_setg_errno errno passing is fixed (-ret) > - fixed logical error in hmp_loadvm (vm_start on error) > - NOT switched to error_prepend code (it is not yet merged). Can we do this > later? This will make my life easear merging code to our downstream. > > Changes from v1: > - cosmetic fixes suggested by Markus. I pray I have added all of them > - patch 5 is rewritten completely. Original one was deadbeaf > > Denis V. Lunev (5): > qmp: process system-reset event in paused state > qmp: create qmp_savevm command > qmp: create qmp_delvm command > migration: improve error reporting for load_vmstate > qmp: create QMP implementation of loadvm command > > hmp.c | 14 +++++++-- > include/migration/migration.h | 2 -- > include/sysemu/sysemu.h | 2 +- > migration/savevm.c | 56 ++++++++++++++++++++-------------- > monitor.c | 9 +++--- > qapi-schema.json | 39 ++++++++++++++++++++++++ > qmp-commands.hx | 71 +++++++++++++++++++++++++++++++++++++++++++ > qmp.c | 4 +++ > vl.c | 4 ++- > 9 files changed, 168 insertions(+), 33 deletions(-) > pls disregard this. patch 1 is stale and from the different set. Sorry :(