From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZbp-0000OP-D0 for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:09:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHZbm-0003HO-JD for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:09:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZbm-0003HI-E0 for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:09:46 -0500 References: <1452265115-27177-1-git-send-email-markmb@redhat.com> <568FDB9F.7080709@redhat.com> <20160108170551.304fe666@markmb_rh> From: Paolo Bonzini Message-ID: <568FDF43.8030200@redhat.com> Date: Fri, 8 Jan 2016 17:09:39 +0100 MIME-Version: 1.0 In-Reply-To: <20160108170551.304fe666@markmb_rh> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Add optionrom compatible with fw_cfg DMA version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc_Mar=c3=ad?= Cc: "Gabriel L. Somlo" , Kevin O'Connor , Laszlo Ersek , qemu-devel , Stefan Hajnoczi On 08/01/2016 17:05, Marc Mar=C3=AD wrote: >> > Do you even need to go to 32-bit mode? The only reason to do so in >> > the original ROM was to do a "rep insb" above 1 GB, but here fw_cfg >> > can do DMA to high addresses for you. > There's no need of course. I was looking at the original ROM and I did > not think this through. Nice, this should make the code much simpler! Paolo