From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZgW-0002g6-VY for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:14:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHZgU-0004xa-8f for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:14:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZgU-0004xO-0x for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:14:38 -0500 References: <1449240275-26196-1-git-send-email-den@openvz.org> <1449240275-26196-2-git-send-email-den@openvz.org> <567B11BA.4090901@redhat.com> <568F9D24.6090803@openvz.org> From: Eric Blake Message-ID: <568FE068.9040203@redhat.com> Date: Fri, 8 Jan 2016 09:14:32 -0700 MIME-Version: 1.0 In-Reply-To: <568F9D24.6090803@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M3G5l0fX123p4cr46X1RqDEBpwkecia65" Subject: Re: [Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Amit Shah , Markus Armbruster , qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M3G5l0fX123p4cr46X1RqDEBpwkecia65 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/08/2016 04:27 AM, Denis V. Lunev wrote: >>> /* Delete old snapshots of the same name */ >>> if (name && bdrv_all_delete_snapshot(name, &bs1, &local_err) < >>> 0) { >>> - monitor_printf(mon, >>> - "Error while deleting snapshot on device >>> '%s': %s\n", >>> - bdrv_get_device_name(bs1), >>> error_get_pretty(local_err)); >>> + error_setg(errp, "Error while deleting snapshot on device >>> '%s': %s", >>> + bdrv_get_device_name(bs1), >>> error_get_pretty(local_err)); >> Markus' series to add a prefixing notation would be better to use here= >> (although I didn't check if he caught this one in that series already)= : >> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03495.html >=20 > this series is not yet merged. I think that we could do this refactorin= g > later on. > This thing could be considered independent. Anyway, this series has its= > own value > and it takes a lot of time to push it in. Could we do error setting > improvement later on? I don't care who rebases on top of the other, but maybe Markus will have an opinion when he gets back online next week. >>> + >>> + if (local_err !=3D NULL) { >> I would have just written 'if (local_err) {'; but that's minor style. > from my point of view explicit !=3D NULL exposes that local_err is a > pointer rather than a boolean value. But the code base already overwhelmingly relies on C's implicit conversion of pointer to a boolean context, as it requires less typing; being verbose doesn't make the code base any easier to read. However, since HACKING doesn't say one way or the other, I won't make you change. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M3G5l0fX123p4cr46X1RqDEBpwkecia65 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWj+BoAAoJEKeha0olJ0NqResH/jhl38ejuBIuf8SbYcLNVDZu J9c1opcUffdWpV/hum6AvoUWOiuAlhGdmyIkixxJAlPakCT2VS1n6KGh2OyOrMnP Ths5Ve7WCKKX4anoqc1HuCbhCFXXeTxagK81nLlR1k3QSR5hyZIzYijB/yxaFUUI OObOsy+ioWmaI5gD5gd+d4lCa8uatTqP1npeEJVpxGbcoJkIKVfvcAro9SYqoZle st0ahbFwh0LjhZ4ieWQhqFJjXt+TTvCrfeEbqUiokl1PGiMzoBHRtn+JDUEkDKHz /0FGOPyTh4HLTzFm2WDK04s+11YjrzQ9wBgP4i9T7vWUz35Eax+VPFn143ER3jQ= =pGC7 -----END PGP SIGNATURE----- --M3G5l0fX123p4cr46X1RqDEBpwkecia65--