From: Richard Henderson <rth@twiddle.net>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [RFC 0/2] tcg-icount: Add and use tcg_set_insn_param to update tcg insn params
Date: Fri, 8 Jan 2016 08:43:37 -0800 [thread overview]
Message-ID: <568FE739.2000102@twiddle.net> (raw)
In-Reply-To: <1452270356-26373-1-git-send-email-edgar.iglesias@gmail.com>
On 01/08/2016 08:25 AM, Edgar E. Iglesias wrote:
> To do so, we'd need to first emit the insn_start and then after translating the
> given target-insn, update the insn_start parameters with the decoded insn
> details.
Fair enough.
> Any thoughts on this approach? Or ideas on better options to achieve this?
This looks like a nice cleanup already.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2016-01-08 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 16:25 [Qemu-devel] [RFC 0/2] tcg-icount: Add and use tcg_set_insn_param to update tcg insn params Edgar E. Iglesias
2016-01-08 16:25 ` [Qemu-devel] [RFC 1/2] tcg: Add tcg_set_insn_param Edgar E. Iglesias
2016-01-08 16:25 ` [Qemu-devel] [RFC 2/2] gen-icount: Use tcg_set_insn_param Edgar E. Iglesias
2016-01-08 16:43 ` Richard Henderson [this message]
2016-01-11 20:16 ` [Qemu-devel] [RFC 0/2] tcg-icount: Add and use tcg_set_insn_param to update tcg insn params Lluís Vilanova
2016-01-11 22:29 ` Peter Maydell
2016-01-12 12:12 ` Lluís Vilanova
2016-01-12 13:52 ` Edgar E. Iglesias
2016-01-12 16:36 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FE739.2000102@twiddle.net \
--to=rth@twiddle.net \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).