From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHbF8-00009L-1m for qemu-devel@nongnu.org; Fri, 08 Jan 2016 12:54:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHbF4-00018A-QW for qemu-devel@nongnu.org; Fri, 08 Jan 2016 12:54:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHbF4-000185-I3 for qemu-devel@nongnu.org; Fri, 08 Jan 2016 12:54:26 -0500 References: <1449240275-26196-1-git-send-email-den@openvz.org> <1449240275-26196-2-git-send-email-den@openvz.org> <567B11BA.4090901@redhat.com> <568F9D24.6090803@openvz.org> <568FE068.9040203@redhat.com> <568FE672.3040401@openvz.org> From: Eric Blake Message-ID: <568FF7CD.3070901@redhat.com> Date: Fri, 8 Jan 2016 10:54:21 -0700 MIME-Version: 1.0 In-Reply-To: <568FE672.3040401@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RJUR9RlU4ged0SSJkgj02iFix99FNxjrg" Subject: Re: [Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Amit Shah , Markus Armbruster , qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RJUR9RlU4ged0SSJkgj02iFix99FNxjrg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/08/2016 09:40 AM, Denis V. Lunev wrote: >>>> Markus' series to add a prefixing notation would be better to use he= re >>>> (although I didn't check if he caught this one in that series alread= y): >>>> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03495.html >>> this series is not yet merged. I think that we could do this refactor= ing >>> later on. >>> This thing could be considered independent. Anyway, this series has i= ts >>> own value >>> and it takes a lot of time to push it in. Could we do error setting >>> improvement later on? >> I don't care who rebases on top of the other, but maybe Markus will ha= ve >> an opinion when he gets back online next week. >> > why we have to wait with this set due to this reason? One of you will have to rebase on the other - either you wait for Markus' error_prepend to go in and you use it, or your patch goes in and Markus updates his error_prepend patch to cover your additional instance that will be benefitted by it. I don't care which, and the timing is really up to the maintainers and how fast they send pull requests. > The code with error_prepend and current code are BOTH > correct. One is a bit shorter then other. Yes, it would > be nice to switch to it, but why this should be done in > this set? Exactly, we're saying the same things. >>>>> + if (local_err !=3D NULL) { >>>> I would have just written 'if (local_err) {'; but that's minor style= =2E >>> from my point of view explicit !=3D NULL exposes that local_err is a >>> pointer rather than a boolean value. >> But the code base already overwhelmingly relies on C's implicit >> conversion of pointer to a boolean context, as it requires less typing= ; >> being verbose doesn't make the code base any easier to read. However,= >> since HACKING doesn't say one way or the other, I won't make you chang= e. >> > I do not understand your last words. >=20 > I am not agitating you with one approach or another. This > is a reason why I am writing code this way. The code written > this way looks better to me. This code is NEW and this does > not contradict any written rule in coding style policy. >=20 > If the code is working and correct, can we just move on with it? Once again, we are saying the same thing. I pointed out a cosmetic issue, but one where I do not have a strong enough leg to stand on to force you to change your style, so what you did is fine as is. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RJUR9RlU4ged0SSJkgj02iFix99FNxjrg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWj/fNAAoJEKeha0olJ0Nq1MkH/1AZCVn5EtOd7F8wCo8VM+tI LiSXbxQccXSMwcLv1N9vHhK22y2qpeKXfUyl71y3+StZMECO2p9FE7lxJPGQ9HxX 0wba/GrAc7klu+cFS5aO2jryaRClRUhemjrhIx2FA5VjAObAsNIiV9UilQ7/0KPQ 0JM9KYdX2ZOSkSQ2bFw7zlYlnDsuxEpEGppdB5sg0Yzde8Azt/XkilCB3N2vDXEM F61P0+iYlOa3jqO0qf9cbbHW2nurZaFqr4TsvkDZ9AaDjTQasZojua9rRnsvhE+x TFKu65LUFjK6kp0Her/WRDIq7fv6JhwvejcJTNRquZqUEx9605V4tbyY4dTbocU= =wwqs -----END PGP SIGNATURE----- --RJUR9RlU4ged0SSJkgj02iFix99FNxjrg--