From: Jason Wang <jasowang@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org,
zhangchen.fnst@cn.fujitsu.com, samuel.thibault@ens-lyon.org
Subject: Re: [Qemu-devel] [PATCH] ether/slirp: Avoid redefinition of the same constants
Date: Mon, 11 Jan 2016 13:20:30 +0800 [thread overview]
Message-ID: <56933B9E.3060609@redhat.com> (raw)
In-Reply-To: <87y4c0avif.fsf@linaro.org>
On 01/09/2016 12:25 AM, Alex Bennée wrote:
> Dr. David Alan Gilbert (git) <dgilbert@redhat.com> writes:
>
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> eth.h and slirp.h both define ETH_ALEN and ETH_P_IP
>> rtl8139.c and eth.h both define ETH_HLEN
>>
>> Move the related constant (ETH_P_ARP) from slirp.h to eth.h, and
>> remove the duplicates; make slirp.h include eth.h
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Applied, thanks.
prev parent reply other threads:[~2016-01-11 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 14:41 [Qemu-devel] [PATCH] ether/slirp: Avoid redefinition of the same constants Dr. David Alan Gilbert (git)
2016-01-08 16:25 ` Alex Bennée
2016-01-11 5:20 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56933B9E.3060609@redhat.com \
--to=jasowang@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dgilbert@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).