From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIUuL-0005hn-Ko for qemu-devel@nongnu.org; Mon, 11 Jan 2016 00:20:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIUuI-0005en-E2 for qemu-devel@nongnu.org; Mon, 11 Jan 2016 00:20:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIUuI-0005ej-8Q for qemu-devel@nongnu.org; Mon, 11 Jan 2016 00:20:42 -0500 References: <1452264088-17383-1-git-send-email-dgilbert@redhat.com> <87y4c0avif.fsf@linaro.org> From: Jason Wang Message-ID: <56933B9E.3060609@redhat.com> Date: Mon, 11 Jan 2016 13:20:30 +0800 MIME-Version: 1.0 In-Reply-To: <87y4c0avif.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] ether/slirp: Avoid redefinition of the same constants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , "Dr. David Alan Gilbert (git)" Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, zhangchen.fnst@cn.fujitsu.com, samuel.thibault@ens-lyon.org On 01/09/2016 12:25 AM, Alex Benn=C3=A9e wrote: > Dr. David Alan Gilbert (git) writes: > >> From: "Dr. David Alan Gilbert" >> >> eth.h and slirp.h both define ETH_ALEN and ETH_P_IP >> rtl8139.c and eth.h both define ETH_HLEN >> >> Move the related constant (ETH_P_ARP) from slirp.h to eth.h, and >> remove the duplicates; make slirp.h include eth.h > Reviewed-by: Alex Benn=C3=A9e Applied, thanks.