From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIXHd-0001QR-Ll for qemu-devel@nongnu.org; Mon, 11 Jan 2016 02:52:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIXHY-0005wf-NF for qemu-devel@nongnu.org; Mon, 11 Jan 2016 02:52:57 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:59988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIXHY-0005wT-Ct for qemu-devel@nongnu.org; Mon, 11 Jan 2016 02:52:52 -0500 References: <1452491930-10210-1-git-send-email-chengang@emindsoft.com.cn> From: Laurent Vivier Message-ID: <56935F3D.10502@vivier.eu> Date: Mon, 11 Jan 2016 08:52:29 +0100 MIME-Version: 1.0 In-Reply-To: <1452491930-10210-1-git-send-email-chengang@emindsoft.com.cn> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Use SOL_SOCKET instead of level for setsockopt() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: chengang@emindsoft.com.cn, riku.voipio@iki.fi Cc: peter.maydell@linaro.org, Chen Gang , qemu-devel@nongnu.org, rth@twiddle.net Le 11/01/2016 06:58, chengang@emindsoft.com.cn a écrit : > From: Chen Gang > > In this case, level is TARGET_SOL_SOCKET, but we need SOL_SOCKET for > setsockopt(). > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 95b1762..44485f2 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -1596,7 +1596,8 @@ set_timeout: > addr_ifname = alloca(IFNAMSIZ); > memcpy(addr_ifname, dev_ifname, optlen); > addr_ifname[optlen] = 0; > - ret = get_errno(setsockopt(sockfd, level, optname, addr_ifname, optlen)); > + ret = get_errno(setsockopt(sockfd, SOL_SOCKET, optname, > + addr_ifname, optlen)); > unlock_user (dev_ifname, optval_addr, 0); > return ret; > } > Reviewed-by: Laurent Vivier