From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIaVK-0005L1-Kn for qemu-devel@nongnu.org; Mon, 11 Jan 2016 06:19:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIaVG-0003PO-Kt for qemu-devel@nongnu.org; Mon, 11 Jan 2016 06:19:18 -0500 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:33069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIaVG-0003PC-EY for qemu-devel@nongnu.org; Mon, 11 Jan 2016 06:19:14 -0500 Received: by mail-wm0-x233.google.com with SMTP id f206so208410453wmf.0 for ; Mon, 11 Jan 2016 03:19:14 -0800 (PST) References: <1452093205-30167-1-git-send-email-eric.auger@linaro.org> <1452093205-30167-8-git-send-email-eric.auger@linaro.org> <20160111024554.GD22925@voom.redhat.com> From: Eric Auger Message-ID: <56938FA3.5070600@linaro.org> Date: Mon, 11 Jan 2016 12:18:59 +0100 MIME-Version: 1.0 In-Reply-To: <20160111024554.GD22925@voom.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: b.reynal@virtualopensystems.com, peter.maydell@linaro.org, thuth@redhat.com, eric.auger@st.com, patches@linaro.org, crosthwaitepeter@gmail.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, qemu-arm@nongnu.org, suravee.suthikulpanit@amd.com, pbonzini@redhat.com, thomas.lendacky@amd.com, alex.bennee@linaro.org, christoffer.dall@linaro.org Hi David, On 01/11/2016 03:45 AM, David Gibson wrote: > On Wed, Jan 06, 2016 at 03:13:25PM +0000, Eric Auger wrote: >> qemu_fdt_setprop self-exists in case of error hence no need to check >> the returned value. >> >> Signed-off-by: Eric Auger > > This change is fine, but in general I'm disinclined to invest too much > in the qemu interfaces for manipulating flattened trees. > > I think our device tree manipulation in qemu is now complicated enough > that we should move towards using an unflattened (i.e. pointer based) > DT representation inside qemu, which is generally more suitable for > complex manipulation. OK. Is there any user-space library available for un-flattened tree manipulation? I only found references to kernel unflattened tree manipulations (drivers/of/fdt.c, include/linux/of.h) and dtc flattree.c. Besides the indicated direction do I understand correctly that you do not reject the series? Best Regards Eric > > That would then get flattened into a blob for the guest in a single > pass at reset time. >