From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>, Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Qemu devel <qemu-devel@nongnu.org>,
Donghai Zdh <donghai.zdh@alibaba-inc.com>
Subject: Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value
Date: Mon, 11 Jan 2016 13:28:06 +0100 [thread overview]
Message-ID: <56939FD6.2040002@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1601111248240.17226@wniryva>
On 11/01/2016 08:23, P J P wrote:
> Hello,
>
> +-- On Wed, 6 Jan 2016, P J P wrote --+
> | When processing firmware configurations, an OOB r/w access occurs
> | if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0xffff).
> | Add a check to validate 's->cur_entry' to avoid such access.
> |
> | Reported-by: Donghai Zdh <donghai.zdh@alibaba-inc.com>
> | Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> | ---
> | hw/nvram/fw_cfg.c | 12 ++++++++----
> | 1 file changed, 8 insertions(+), 4 deletions(-)
> |
> | Updated as per review in
> | -> https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00398.html
>
>
> -> https://patchwork.ozlabs.org/patch/563706/
>
> Ping...! Does it look okay? (just checking)
Yes, it looks good.
Paolo
next prev parent reply other threads:[~2016-01-11 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 6:16 [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value P J P
2016-01-11 7:23 ` P J P
2016-01-11 12:28 ` Paolo Bonzini [this message]
2016-01-11 16:34 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56939FD6.2040002@redhat.com \
--to=pbonzini@redhat.com \
--cc=donghai.zdh@alibaba-inc.com \
--cc=peter.maydell@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).