qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, den@openvz.org, famz@redhat.com,
	stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification
Date: Mon, 11 Jan 2016 12:07:25 -0500	[thread overview]
Message-ID: <5693E14D.6000708@redhat.com> (raw)
In-Reply-To: <56939E25.9000309@virtuozzo.com>



On 01/11/2016 07:20 AM, Vladimir Sementsov-Ogievskiy wrote:
> 
> Are you sure? What about creation\last change dates, file links, user
> data, etc?
> For now, formally, current "For now, as no extra data is defined,
> extra_data_size is reserved and must be zero." is equal to such table,
> but provides more flexibility for future..

Oh, I see what you're trying to do.

In this case, perhaps we need a versioning system for the type-specific
data? We won't be able to just add data arbitrarily, we need to change
some field somewhere.

Maybe we can say something like...

"If extra_data_size is 0, there is no type-specific data and the version
of that data layout is 0. If extra_data_size is non-zero, the first byte
of the type-specific-data must be a version number greater than 0 that
indicates the layout of the data to follow.

For the Dirty Tracking bitmap type, only version 0 is currently valid."

This way it's explicit that data *could* show up for dirty tracking in
the future, but currently it does not.

--js

  reply	other threads:[~2016-01-11 17:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 17:49 [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification Vladimir Sementsov-Ogievskiy
2015-12-23 22:31 ` Max Reitz
2015-12-24 10:10   ` Vladimir Sementsov-Ogievskiy
2015-12-23 23:41 ` Eric Blake
2015-12-24 10:00   ` Vladimir Sementsov-Ogievskiy
2016-01-04 22:34     ` John Snow
2016-01-04 22:21 ` Max Reitz
2016-01-04 23:16 ` John Snow
2016-01-11 12:20   ` Vladimir Sementsov-Ogievskiy
2016-01-11 17:07     ` John Snow [this message]
2016-01-12  8:30       ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5693E14D.6000708@redhat.com \
    --to=jsnow@redhat.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).